Fix typo in no clbit case qpy generation - #27
Merged
Merged
Conversation
In Qiskit#17 the logic check was done backwards. Specifically the condition was an empty vec should be used if there are no clbits, but the if condition was incorrectly using vec![] if there were clbits. This commit fixes the oversight and corrects the logic so it is only populating the classical registers field in the QPY if there are any clbits (not if there are not any clbits).
Member
Author
|
I need to write a test suite for the qpy generation to avoid bugs like this in the future. It was supposed to be short lived until Qiskit/qiskit#15977, but that is taking a bit longer than I originally had hoped so we should have this better tested. The best way to test this will be through Python |
Jim Garrison (garrison)
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #17 the logic check was done backwards. Specifically the condition was an empty vec should be used if there are no clbits, but the if condition was incorrectly using vec![] if there were clbits. This commit fixes the oversight and corrects the logic so it is only populating the classical registers field in the QPY if there are any clbits (not if there are not any clbits).