QPY: Bug fix in Rust implementation of SparsePauliObservableElemPack - #16788
Open
gadial wants to merge 2 commits into
Open
QPY: Bug fix in Rust implementation of SparsePauliObservableElemPack#16788gadial wants to merge 2 commits into
SparsePauliObservableElemPack#16788gadial wants to merge 2 commits into
Conversation
ShellyGarion
added
the
Changelog: Fixed
Coverage Report for CI Build 32117132256Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage increased (+0.04%) to 87.818%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions11 previously-covered lines in 3 files lost coverage.
Coverage Stats
💛 - Coveralls |
Collaborator
|
One or more of the following people are relevant to this code:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug in the way Rust QPY serializes and deserializes
SparsePauliObservableElemPack.Fixes #16722
Details
When serializing
SparsePauliObservableElemPack, there are several lists of elements being serialized. While Rust stored the lengths of the lists, Python stored the actual sizes of the serialized lists. It is possible to make sure Rust conforms to this serialization by dividing and multiplying by the correct factors (dependent on the known sizes of the stored elements).AI/LLM disclosure