Skip to content

Adding quickcheck for complete graph#1471

Merged
IvanIsCoding merged 3 commits into
Qiskit:mainfrom
Krishn1412:quickcheck_complete_graph
Jun 29, 2025
Merged

Adding quickcheck for complete graph#1471
IvanIsCoding merged 3 commits into
Qiskit:mainfrom
Krishn1412:quickcheck_complete_graph

Conversation

@Krishn1412

Copy link
Copy Markdown
Contributor

To verify the structural integrity of complete graph, we check the number of nodes, edges and whether all expected edges exist.

To verify the structural integrity of complete graph, we check the number of nodes, edges and whether all expected edges exist.
@Krishn1412

Copy link
Copy Markdown
Contributor Author

hey @IvanIsCoding, is this failing because of some other changes?

@IvanIsCoding

Copy link
Copy Markdown
Collaborator

@Krishn1412 yes, with Rust 1.88 Clippy got updated which added new lints that now fail CI.

I will send a separate PR to fix it

@IvanIsCoding

Copy link
Copy Markdown
Collaborator

I temporarily disabled the failing lints, I will fix them in a separate PR.

@IvanIsCoding IvanIsCoding enabled auto-merge June 29, 2025 01:57
@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 15950401187

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 72 unchanged lines in 19 files lost coverage.
  • Overall coverage decreased (-0.6%) to 94.575%

Files with Coverage Reduction New Missed Lines %
rustworkx-core/src/centrality.rs 1 98.59%
rustworkx-core/src/generators/random_graph.rs 1 70.28%
rustworkx-core/src/steiner_tree.rs 1 96.55%
src/coloring.rs 1 98.82%
src/connectivity/johnson_simple_cycles.rs 1 97.44%
src/layout/spring.rs 1 99.56%
rustworkx-core/src/connectivity/biconnected.rs 2 97.62%
src/isomorphism/vf2.rs 2 96.01%
src/toposort.rs 2 89.38%
rustworkx-core/src/token_swapper.rs 3 95.59%
Totals Coverage Status
Change from base Build 15890388565: -0.6%
Covered Lines: 17783
Relevant Lines: 18803

💛 - Coveralls

@IvanIsCoding IvanIsCoding added this pull request to the merge queue Jun 29, 2025
Merged via the queue into Qiskit:main with commit 34ffae4 Jun 29, 2025
31 checks passed
SILIZ4 pushed a commit to SILIZ4/rustworkx that referenced this pull request Jul 4, 2025
* Adding quickcheck for complete graph

To verify the structural integrity of complete graph, we check the number of nodes, edges and whether all expected edges exist.

* Add ignore for files temporarily

* Address lint in test target as well

---------

Co-authored-by: Ivan Carvalho <ivancarvalho@gatech.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants