Implement dialect translators #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngrislain
reviewed
Dec 15, 2023
src/dialect_translation/mod.rs
Outdated
|
|
||
| // expand arms for nullay | ||
| $( | ||
| expr::function::Function::$nullay => $self.[<from_ $nullay:snake>](), |
ngrislain
reviewed
Dec 15, 2023
src/dialect_translation/mod.rs
Outdated
| /// We use macros to reduce code repetition in generating functions to convert each Epression variant. | ||
| macro_rules! into_dialect_tranlator_trait_constructor { | ||
| () => { | ||
| pub trait IntoDialectTranslator { |
There was a problem hiding this comment.
RelationToQueryTranslator
ngrislain
reviewed
Dec 15, 2023
src/dialect_translation/mod.rs
Outdated
| /// Build Sarus Relatioin from dialect speciific AST | ||
| // macro_rules! into_ralation_tranlator_trait_constructor { | ||
| // () => { | ||
| pub trait IntoRelationTranslator { |
There was a problem hiding this comment.
QueryToRelationTranslator
ngrislain
reviewed
Dec 15, 2023
src/dialect_translation/mod.rs
Outdated
| } | ||
| } | ||
|
|
||
| fn from_column(&self, ident: &expr::Identifier) -> ast::Expr { |
ngrislain
reviewed
Dec 15, 2023
src/dialect_translation/mod.rs
Outdated
| let ast_expr = self.expr(expr); | ||
| cast_builder(ast_expr, ast::DataType::Datetime(Some(64))) | ||
| } | ||
| fn from_case(&self, exprs: Vec<&expr::Expr>) -> ast::Expr { |
ngrislain
reviewed
Dec 15, 2023
src/dialect_translation/mod.rs
Outdated
| fn dialect(&self) -> Self::D; | ||
|
|
||
| // It converts ast Expressions to sarus expressions | ||
| fn try_from_expr( |
ngrislain
approved these changes
Dec 18, 2023
ngrislain
reviewed
Dec 18, 2023
src/display/mod.rs
Outdated
| .expect("Error: this works on MacOS"); | ||
| .or( | ||
| Command::new("xdg-open") | ||
| .arg(format!("http://localhost:8000/{name}.html")) |
There was a problem hiding this comment.
This will not work, remove
There was a problem hiding this comment.
This is needed to visualise the relations and run some tests individually when the repository is in a remote linux machine. it requires to run a html server in the /tmp/ directory. It is not general but it allows me to run some individual tests in my development environment.
ngrislain
reviewed
Dec 18, 2023
src/display/mod.rs
Outdated
| .expect("Error: this works on MacOS"); | ||
| .or( | ||
| Command::new("xdg-open") | ||
| .arg(format!("http://localhost:8000/{name}.html")) |
There was a problem hiding this comment.
Why did you do that, please remove everywhere.
There was a problem hiding this comment.
I have reverted it and created the issue here
ngrislain
reviewed
Dec 18, 2023
src/relation/mod.rs
Outdated
| @@ -1574,6 +1574,7 @@ impl Ready<Relation> for ValuesBuilder { | |||
| mod tests { | |||
| use super::{schema::Schema, *}; | |||
| use crate::{builder::With, data_type::DataType, display::Dot}; | |||
| use crate::{ast}; | |||
There was a problem hiding this comment.
Why have the {} ?
Can you run cargo fmt?
ngrislain
reviewed
Dec 18, 2023
src/sql/relation.rs
Outdated
| @@ -43,11 +44,15 @@ This is done in the query_names module. | |||
| /// The Hierarchy of Relations is the context in which the query is converted, typically the list of tables with their Path | |||
| /// The QueryNames is the map of sub-query referrenced by their names, so that links can be unfolded | |||
| #[derive(Clone, Debug, Hash, PartialEq, Eq)] | |||
| struct TryIntoRelationVisitor<'a>(&'a Hierarchy<Arc<Relation>>, QueryNames<'a>); | |||
| pub struct TryIntoRelationVisitor<'a, T: QueryToRelationTranslator + Copy + Clone> { | |||
There was a problem hiding this comment.
It is an error. I reverted it
ngrislain
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.