drop Python 3.9 and add support for 3.12 #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
commented
Aug 29, 2024
| dependencies = [ | ||
| "aiofiles", | ||
| "emoji", | ||
| "fastapi", | ||
| "httpx", | ||
| "importlib_metadata>=4.6; python_version<'3.10'", |
There was a problem hiding this comment.
No longer needed, since we at least have 3.10 and thus don't need a backport of importlib.metadata.
There was a problem hiding this comment.
This whole file is no longer needed, since all compatibility functions we had in there are natively supported by Python 3.10 and upwards.
Comment on lines
+34
to
+39
| class UtcDateTime(types.TypeDecorator): | ||
| """UTC timezone aware datetime type. | ||
|
|
||
| This is needed because sqlalchemy.types.DateTime(timezone=True) does not | ||
| consistently store the timezone. | ||
| """ |
| @@ -75,7 +85,7 @@ class Message(BaseModel): | |||
| content: str | |||
| role: ragna.core.MessageRole | |||
| sources: list[Source] = Field(default_factory=list) | |||
| timestamp: datetime.datetime = Field(default_factory=datetime.datetime.utcnow) | |||
There was a problem hiding this comment.
datetime.datetime.utcnow is deprecated starting with Python 3.12 and thus I refactored this whole thing to be timezone aware.
blakerosenthal
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
panel==1.5.*, i.e. the next minor version, drops support for Python 3.9. As we'll need to upgrade at some point, we also do the switch now. In addition, this also adds support for Python 3.12 so we still have three compatible versions.