Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use bokeh_fastapi through panel #503

Draft
wants to merge 3 commits into
base: deploy-dev
Choose a base branch
from
Draft

Conversation

pmeier
Copy link
Member

@pmeier pmeier commented Aug 30, 2024

holoviz/panel#7205 adds support for bokeh_fastapi inside panel. This PR is here to test if everything works. cc @philippjfr

@@ -62,7 +62,7 @@ runs:
run: |
pip install \
git+https://github.com/bokeh/bokeh-fastapi.git@main \
git+https://github.com/holoviz/panel@7377c9e99bef0d32cbc65e94e908e365211f4421
git+https://github.com/holoviz/panel@fastapi_serve
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implicitly updates to panel==1.5.*. Thus, we'll have to check styling as well.

Copy link
Member Author

@pmeier pmeier Aug 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in this file are drivebys of stuff missed in d869bd0.

Comment on lines +87 to +92
for dir in ["css", "imgs"]:
app.mount(
f"/{dir}",
StaticFiles(directory=str(Path(__file__).parent / "_ui" / dir)),
name=dir,
)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably go into BokehFastapi under a static_dirs keyword similar to what pn.serve does.

@pmeier
Copy link
Member Author

pmeier commented Aug 30, 2024

Re #503 (comment). The only difference I found is that the chat interface now seems to fill the whole vertical space of its container whereas before it only occupied the middle area.

panel==1.5.* / PR

image

panel==1.4.4 / main

image

@pmeier
Copy link
Member Author

pmeier commented Aug 30, 2024

I just realized that the document pill in the top-right corner is also missing for panel==1.5.*.

@pmeier
Copy link
Member Author

pmeier commented Sep 13, 2024

Document upload is also broken:

panel == 1.5

image

panel == 1.4.4

image

@pmeier
Copy link
Member Author

pmeier commented Sep 13, 2024

@pierrotsmnrd We can use the FileDropper widget going forward. But if the old one can easily be fixed, we can also do this in a follow-up PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants