-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use bokeh_fastapi through panel #503
base: deploy-dev
Are you sure you want to change the base?
Conversation
.github/actions/setup-env/action.yml
Outdated
@@ -62,7 +62,7 @@ runs: | |||
run: | | |||
pip install \ | |||
git+https://github.com/bokeh/bokeh-fastapi.git@main \ | |||
git+https://github.com/holoviz/panel@7377c9e99bef0d32cbc65e94e908e365211f4421 | |||
git+https://github.com/holoviz/panel@fastapi_serve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implicitly updates to panel==1.5.*
. Thus, we'll have to check styling as well.
ragna/core/_components.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in this file are drivebys of stuff missed in d869bd0.
for dir in ["css", "imgs"]: | ||
app.mount( | ||
f"/{dir}", | ||
StaticFiles(directory=str(Path(__file__).parent / "_ui" / dir)), | ||
name=dir, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably go into BokehFastapi
under a static_dirs
keyword similar to what pn.serve
does.
Re #503 (comment). The only difference I found is that the chat interface now seems to fill the whole vertical space of its container whereas before it only occupied the middle area.
|
I just realized that the document pill in the top-right corner is also missing for |
@pierrotsmnrd We can use the |
holoviz/panel#7205 adds support for
bokeh_fastapi
insidepanel
. This PR is here to test if everything works. cc @philippjfr