Fix combo update grouped-order retrieval in IBPlaceOrder#218
Draft
creatidy wants to merge 1 commit intoQuantConnect:masterfrom
Draft
Fix combo update grouped-order retrieval in IBPlaceOrder#218creatidy wants to merge 1 commit intoQuantConnect:masterfrom
creatidy wants to merge 1 commit intoQuantConnect:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adjusts
IBPlaceOrdergrouped-order retrieval behavior:needsNewId == true): keep current cache-based grouped retrieval.needsNewId == false): retrieve grouped orders from_orderProvider.GetOrderById(...)so a single-leg update request can reliably reconstruct the full combo group.Related Issue
#217
Motivation and Context
Combo updates may arrive through one leg/ticket context, where transient cache-based grouped retrieval is insufficient.
This can cause update-path misses and inconsistent combo update behavior.
Using order-provider-based group reconstruction on updates makes update handling reliable and deterministic.
Requires Documentation Change
No.
How Has This Been Tested?
dotnet build /tmp/ib-pr/QuantConnect.InteractiveBrokersBrokerage/QuantConnect.InteractiveBrokersBrokerage.csproj --no-restoreBrokerageTransactionHandlerTests.ProcessesComboRequestsOnSameThreadWhenConcurrencyIsEnabledBrokerageTransactionHandlerTests.ProcessesOrdersConcurrentlyTypes of changes
Checklist:
bug-<issue#>-<description>Additional note for tests:
This repository does not currently include a focused unit-test harness for this specific grouped update-path edge case in this change set, so coverage is validated by successful build plus companion LEAN regression tests.