Add flexible settlement date#8706
Closed
Marinovsky wants to merge 14 commits intoQuantConnect:masterfrom
Closed
Conversation
1fc59f5 to
61fc1ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I created flexible static properties
Equity.DefaultSettlementDays,Equity.USASettlementDaysHistoryandEquity.InternationalSettlementDaysHistory, as well as their corresponding ones forOptionso that the user can freely modify them. I also added a method inSecurityto compute the settlement days based on a given dictionary of pairs (date, settlement days) and the current time, where the date corresponds to the date the settlement days changed.Related Issue
Closes #8659
Motivation and Context
With this change users will be able to freely modify the settlement days for both equity and options
Requires Documentation Change
N/A
How Has This Been Tested?
I created a unit test that apply funds to a
DefaultBrokerageModeland then asserts the money is settled after the expected settlement days computed bySecurity.GetSettlementDays()Types of changes
Checklist:
bug-<issue#>-<description>orfeature-<issue#>-<description>