Skip to content

Add flexible settlement date#8706

Closed
Marinovsky wants to merge 14 commits intoQuantConnect:masterfrom
Marinovsky:bug-8659-FlexibleSettlementDate
Closed

Add flexible settlement date#8706
Marinovsky wants to merge 14 commits intoQuantConnect:masterfrom
Marinovsky:bug-8659-FlexibleSettlementDate

Conversation

@Marinovsky
Copy link
Copy Markdown
Contributor

@Marinovsky Marinovsky commented Apr 20, 2025

Description

I created flexible static properties Equity.DefaultSettlementDays, Equity.USASettlementDaysHistory and Equity.InternationalSettlementDaysHistory, as well as their corresponding ones for Option so that the user can freely modify them. I also added a method in Security to compute the settlement days based on a given dictionary of pairs (date, settlement days) and the current time, where the date corresponds to the date the settlement days changed.

Related Issue

Closes #8659

Motivation and Context

With this change users will be able to freely modify the settlement days for both equity and options

Requires Documentation Change

N/A

How Has This Been Tested?

I created a unit test that apply funds to a DefaultBrokerageModel and then asserts the money is settled after the expected settlement days computed by Security.GetSettlementDays()

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@Marinovsky Marinovsky force-pushed the bug-8659-FlexibleSettlementDate branch from 1fc59f5 to 61fc1ca Compare May 6, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Backtesting: Flexible Settlement date

2 participants