audit: annotate intro mle's yfinance read - #151
Conversation
QuantEcon/lecture-python-intro#849 (merged 2026-09-29 21:17 UTC) rewrote mle.md to download monthly AMZN prices with yfinance and refit by maximum likelihood the Student's t that fitting_distributions fits by moments. The read has no annotation, so the strict audit fails on main with `missing_api_annotations: lecture-python-intro:mle:yfinance`, and the next push to main or the Monday 05:17 UTC run goes red, opens an audit-drift issue and skips the Pages deploy. The entry follows fitting_distributions', which reads the same series the same way: pedagogy incidental. Checked 2026-09-30 with build_audit.py all --strict over the eight lecture repos at main: exit 1 on main alone, exit 0 with this entry. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The change is correct, but the pedagogy: incidental value is an explicit judgment call the author asked a reviewer to confirm, so it warrants human sign-off rather than automated approval.
Review effort: Balanced
Findings: None
What changed in this PR
This PR adds a single curated judgment entry to scripts/audit_annotations.yml for a newly introduced live-API read. The intro mle lecture was rewritten (lecture-python-intro#849) to download monthly AMZN prices via yfinance, which the audit scanner detects as a new, unannotated reference; without an entry, build_audit.py all --strict fails with missing_api_annotations: lecture-python-intro:mle:yfinance, which would turn the audit-dashboard check red and skip the Pages deploy. Adding the annotation restores a green strict audit on main.
Changes:
- Add an
api:annotation forlecture-python-intro:mle:yfinance(series: AMZN,pedagogy: incidental, with an explanatory note), mirroring the existingfitting_distributions:yfinanceentry.
| File | Description |
|---|---|
scripts/audit_annotations.yml |
Adds the curated mle:yfinance API annotation so the strict audit recognizes intro's new AMZN read and passes on main. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Annotates intro's new
yfinanceread, so that the strict audit passes onmainagain.QuantEcon/lecture-python-intro#849 merged at 2026-09-29 21:17 UTC. It rewrote
mle.mdto download monthly AMZN prices withyfinance(line 880), for a maximum-likelihood refit of the Student's t thatfitting_distributionsfits by moments. That read has no entry inscripts/audit_annotations.yml, sobuild_audit.py all --strictfails withmissing_api_annotations: lecture-python-intro:mle:yfinance. Noaudit-dashboardrun has happened since that merge, so nothing shows red yet. But the next push tomaingoes red and skips the Pages deploy, and the scheduled run on Monday 2026-10-05 at 05:17 UTC would also open anaudit-driftissue.The entry follows
lecture-python-intro:fitting_distributions:yfinance, which reads the same series the same way:series: AMZN,pedagogy: incidental.pedagogyis a judgment; @mmcky confirmedincidentalon 2026-09-30.Checked on 2026-09-30 with
python scripts/build_audit.py all --strictover the eight lecture repos atmain: exit 1 onmainalone with that single warning, and exit 0 with this entry.Merge this first. Every other PR to
mainneeds it for a greenaudit-dashboardcheck, including the licence records (#152) and block C (#153). It turned up while dry-running block C of #118.🤖 Generated with Claude Code