Port dv pda resprites#19
Conversation
|
Give me a bit and i can work on the missing PDAs but a few notes:
Sprites 100% necessary for this PR that i'll work on:
The other senior PDAs missing can just use the regular sprites for now and i can push another PR to deal with them later (in some cases i want to trim down senior roles, for others i can make a new PDA sprite but it's not super super important right now) From glancing at the code the duplicate clear PDAs seem to be PDAs parenting from the clear PDA but not giving it another name. I can't think of why they're done like that instead of giving the roles those are for just regular clear PDAs as is so it might just be a case of unclean code? Should be fine to leave as is but you can try cleaning it up if you'd like |
|
All sprites except for the ones Matt listed above are in and working. Imp senior roles use their non-senior counterparts. |
About the PR
pdas that look good
Why / Balance
it's on the todo doc
Technical details
adds a ton of sprites for DV's PDAs
Media
Removed sprites
QB doesn't have these roles. Please let me know if any should not have been deleted
internservice<-- service worker oops. it's back inMISSING SPRITES
Mostly due to imp having more senior role PDAs
the PDA ad poster also uses the old sprite
Problems
There are 4 listings of the clear PDA in the entity spawn menu. There's only one listing in the yml files.
Librarian PDA uses a widePDA sprite, which makes it look like the old pda, and not the ones in this port.
There is a courier pda (mailcarrier), but couriers' PDA use the cargo PDA sprite. (_imp/.../pda.yml line 281)
Requirements
Changelog