Part 3 - pow: remove pyethash C extension, always use pure Python ethash#973
Open
ping-ke wants to merge 6 commits intoupgrade/py313-baselinefrom
Open
Part 3 - pow: remove pyethash C extension, always use pure Python ethash#973ping-ke wants to merge 6 commits intoupgrade/py313-baselinefrom
ping-ke wants to merge 6 commits intoupgrade/py313-baselinefrom
Conversation
pyethash is a C++ extension that is not compatible with Python 3.13. The pure Python implementation in ethereum.pow.ethash is sufficient. Remove the conditional import and always use the Python path, adding @lru_cache to get_cache_slow for the same performance benefit. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
qzhodl
reviewed
Mar 25, 2026
qzhodl
reviewed
Mar 25, 2026
qzhodl
reviewed
Mar 30, 2026
Add comment explaining why pyethash C++ acceleration was removed (not supported on Python 3.13) with link to #976
2 tasks
qzhodl
approved these changes
Mar 31, 2026
syntrust
reviewed
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pyethash is a C++ extension that is not compatible with Python 3.13. The pure Python implementation in ethereum.pow.ethash is sufficient. Remove the conditional import and always use the Python path, adding @lru_cache to get_cache_slow for the same performance benefit.
Test plan
ImportErroron Python 3.13