Part 2 - db: migrate from python-rocksdb to rocksdict#975
Draft
ping-ke wants to merge 2 commits intoupgrade/py313-baselinefrom
Draft
Part 2 - db: migrate from python-rocksdb to rocksdict#975ping-ke wants to merge 2 commits intoupgrade/py313-baselinefrom
ping-ke wants to merge 2 commits intoupgrade/py313-baselinefrom
Conversation
python-rocksdb is unmaintained and incompatible with Python 3.13. Switch to rocksdict which provides an actively maintained Python binding for RocksDB with a compatible but slightly different API. Changes: - Update Options API (method-style setters instead of attribute assignment) - Replace iteritems() with iter() + manual key/value/next() calls - Fix multi_get() to return dict from list result - Add close() call (rocksdict supports it, python-rocksdb didn't) - Update Dockerfile to install build dependencies for rocksdict Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a copy of PR #967