Merged
Conversation
32 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #377 +/- ##
==========================================
- Coverage 76.13% 76.11% -0.03%
==========================================
Files 53 53
Lines 9222 9222
==========================================
- Hits 7021 7019 -2
- Misses 2201 2203 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ben-grande
force-pushed
the
preload-mem-threshold
branch
from
4542f6e to
ba79054
Compare
marmarek
reviewed
Aug 2, 2025
doc/manpages/qvm-features.rst
Outdated
|
|
||
| Memory size in MiB to deduct (on calculation only) from system's available | ||
| memory. The resulting value is considered before trying to preload to avoid | ||
| exhausting system's memory. |
Member
There was a problem hiding this comment.
This description isn't quite clear what that feature does. Maybe better something like "Memory size in MiB to leave free when preloading disposables. If preloading a disposable would leave less memory, it's skipped".
@andrewdavidwong any better idea?
Member
There was a problem hiding this comment.
Or maybe something based on comments in the other PR (QubesOS/qubes-desktop-linux-manager#272)
Member
There was a problem hiding this comment.
How about: "The amount of free system memory that will never be used for preloading disposables. Ensures preloaded disposables do not consume all available memory."
ben-grande
force-pushed
the
preload-mem-threshold
branch
from
ba79054 to
59d1f19
Compare
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025080604-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025061004-4.3&flavor=update
Failed tests9 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/142375#dependencies 10 fixed
Unstable testsDetailsPerformance TestsPerformance degradation:9 performance degradations
Remaining performance tests:164 tests
|
This was referenced Aug 4, 2025
marmarek
approved these changes
Aug 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For: QubesOS/qubes-core-admin#710
For: QubesOS/qubes-issues#10027
For: QubesOS/qubes-issues#1512