Skip to content

Document kernel option-related features#435

Open
RandyTheOtter wants to merge 1 commit intoQubesOS:mainfrom
RandyTheOtter:document_kernelopts
Open

Document kernel option-related features#435
RandyTheOtter wants to merge 1 commit intoQubesOS:mainfrom
RandyTheOtter:document_kernelopts

Conversation

@RandyTheOtter
Copy link

No description provided.

@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.24%. Comparing base (aade160) to head (9c5395a).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #435      +/-   ##
==========================================
+ Coverage   76.17%   76.24%   +0.07%     
==========================================
  Files          53       53              
  Lines        9312     9325      +13     
==========================================
+ Hits         7093     7110      +17     
+ Misses       2219     2215       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

no-default-kernelopts
^^^^^^^^^^^^^^^^^^^^^

When set, qube is started without default kernel options, which include
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add something like:

Suggested change
When set, qube is started without default kernel options, which include
When set, qube is started without default kernel options (in addition to kernelopts property), which include

to make it clear it's about options not already visible in kernelopts property.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way it may seem like this feature disables both... (although the next sentence should clarify it to the reader)

Perhaps something like this:

Suggested change
When set, qube is started without default kernel options, which include
When set, qube is started without default kernel options, which include
``root=...``. This feature does not affect options provided by the
``kernelopts`` property.

It also makes it obvious that kernelopts works regardless of no-default-kernelopts

@ben-grande
Copy link
Contributor

When ready for review, please squash the commits.

    squash commits:
    9c5395a qvm-features.rst : clarify use of `ketnelopts`
    de77fbf qvm-features.rst : fix `no-nomodeset` default
    2191da2 qvm-features.rst : remove accidental trailing newline
    9ec24c2 qvm-features.rst : document kernelopt-related features
@RandyTheOtter RandyTheOtter marked this pull request as ready for review March 13, 2026 02:21
@RandyTheOtter
Copy link
Author

Marek isn't answering, I follow my assumption of his intent

@RandyTheOtter RandyTheOtter requested a review from marmarek March 16, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants