Skip to content

Add type hints for device_protocol.py #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marmarek merged 1 commit into from
Mar 15, 2026
Merged

Add type hints for device_protocol.py #437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions qubesadmin/backup/core3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,10 @@

import qubesadmin.backup
import qubesadmin.firewall
from qubesadmin import device_protocol
from qubesadmin import utils
from qubesadmin.vm import QubesVM




class Core3VM(qubesadmin.backup.BackupVM):
'''VM object'''
@property
Expand Down Expand Up @@ -138,7 +136,7 @@ def import_core3_vm(self, element: _Element) -> None:
for opt_node in node.findall('./option'):
opt_name = opt_node.get('name')
options[opt_name] = opt_node.text
options['required'] = device_protocol.qbool(
options['required'] = utils.qbool(
node.get('required', 'yes'))
vm.devices[bus_name][(backend_domain, port_id)] = options

Expand Down
Loading