Skip to content

Add type hints for firewall.py#441

Merged
marmarek merged 2 commits intoQubesOS:mainfrom
hippalectryon-0:typing-firewall
Mar 15, 2026
Merged

Add type hints for firewall.py#441
marmarek merged 2 commits intoQubesOS:mainfrom
hippalectryon-0:typing-firewall

Conversation

@hippalectryon-0
Copy link

@hippalectryon-0 hippalectryon-0 commented Mar 1, 2026

Follows #440

@codecov
Copy link

codecov bot commented Mar 1, 2026

Codecov Report

❌ Patch coverage is 99.01961% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 76.36%. Comparing base (71fab5b) to head (6199cf1).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
qubesadmin/devices.py 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #441      +/-   ##
==========================================
+ Coverage   76.35%   76.36%   +0.01%     
==========================================
  Files          53       53              
  Lines        9388     9398      +10     
==========================================
+ Hits         7168     7177       +9     
- Misses       2220     2221       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hippalectryon-0 hippalectryon-0 marked this pull request as ready for review March 15, 2026 13:55
@marmarek marmarek merged commit 386de45 into QubesOS:main Mar 15, 2026
4 of 6 checks passed
@hippalectryon-0 hippalectryon-0 deleted the typing-firewall branch March 16, 2026 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants