qvm-template-postprocess: add installation complete message#444
Open
therohityadav wants to merge 1 commit intoQubesOS:mainfrom
Open
qvm-template-postprocess: add installation complete message#444therohityadav wants to merge 1 commit intoQubesOS:mainfrom
therohityadav wants to merge 1 commit intoQubesOS:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #444 +/- ##
=======================================
Coverage 76.24% 76.25%
=======================================
Files 53 53
Lines 9322 9323 +1
=======================================
+ Hits 7108 7109 +1
Misses 2214 2214 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
I don't think this is enough to close the issue, because it's also asking for GUI changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the final user-facing log during template installation is
"Importing data ...", which leaves users uncertain if the background post-installation tasks have finished.Add an explicit info log at the end of the
post_installfunction to provide a clear, unmistakable signal that the template installation is fully complete.Fixes QubesOS/qubes-issues#10753