Simplify flag handling in qvm_ls#447
Open
hippalectryon-0 wants to merge 2 commits intoQubesOS:mainfrom
Open
Conversation
added 2 commits
March 10, 2026 14:55
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #447 +/- ##
==========================================
+ Coverage 76.24% 76.36% +0.11%
==========================================
Files 53 53
Lines 9322 9282 -40
==========================================
- Hits 7108 7088 -20
+ Misses 2214 2194 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
qvm_lshas a huge chunk of code dedicated to handling flags - that appears to be remnant of an old, mostly unused implementation.This PR greatly simplifies this logic by transforming
flagsinto just another standardColumn.This PR shouldn't change any user-facing feature.
Minor changes
Columns