Skip to content

Simplify flag handling in qvm_ls#447

Open
hippalectryon-0 wants to merge 2 commits intoQubesOS:mainfrom
hippalectryon-0:improve_qvm_ls_qubesmain
Open

Simplify flag handling in qvm_ls#447
hippalectryon-0 wants to merge 2 commits intoQubesOS:mainfrom
hippalectryon-0:improve_qvm_ls_qubesmain

Conversation

@hippalectryon-0
Copy link

Purpose

qvm_ls has a huge chunk of code dedicated to handling flags - that appears to be remnant of an old, mostly unused implementation.

This PR greatly simplifies this logic by transforming flags into just another standard Column.
This PR shouldn't change any user-facing feature.

Minor changes

  • Light reformatting / cleanup of Columns
  • Add new utests

@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

❌ Patch coverage is 70.00000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.36%. Comparing base (1a623d1) to head (fd70a12).

Files with missing lines Patch % Lines
qubesadmin/tools/qvm_ls.py 70.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #447      +/-   ##
==========================================
+ Coverage   76.24%   76.36%   +0.11%     
==========================================
  Files          53       53              
  Lines        9322     9282      -40     
==========================================
- Hits         7108     7088      -20     
+ Misses       2214     2194      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant