Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #453 +/- ##
==========================================
+ Coverage 76.20% 76.38% +0.18%
==========================================
Files 53 54 +1
Lines 9359 9444 +85
==========================================
+ Hits 7132 7214 +82
- Misses 2227 2230 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| try: | ||
| stdout, _stderr = vm.run_service_for_stdio( | ||
| "qubes.GetImageRGBA", input=filepath.encode() |
There was a problem hiding this comment.
Assuming I understood this correctly, it is doing the conversion in the same qube the image is in. This has the problem of trusting the image. Because you downloaded the image to that qube, doesn't mean you trust to open it in that qube. That is why conversions happen in disposable qubes.
In short:
There was a problem hiding this comment.
TBH, I'm not sure if this is really a valid concern. If somebody doesn't trust the image, they can always call qvm-convert-img before doing anything else with the file. Which would be a good idea in that case anyway, to avoid for example file manager loading it for preview.
|
I think this PR should be in https://github.com/QubesOS/qubes-app-linux-img-converter |
Closes QubesOS/qubes-issues#215
This adds
qvm-set-wallpaper, which safely converts an image from another VM usingqubes.GetImageRGBAand sets it as the current VM's wallpaper.Note: parts of this PR, e.g. utests, are GenAI generated and human-reviewed
TODO before marking as ready: