tools: fix vm.run(user="root") on template imported from R4.2 (cont)#467
Open
marmarek wants to merge 1 commit intoQubesOS:mainfrom
Open
tools: fix vm.run(user="root") on template imported from R4.2 (cont)#467marmarek wants to merge 1 commit intoQubesOS:mainfrom
marmarek wants to merge 1 commit intoQubesOS:mainfrom
Conversation
Template imported from R4.2 already has qubes.VMRootShell service, but
it isn't really running as root by default. It's only R4.3+ when both
qubes.VMRootShell and qubes.VMRootExec got also force-user=root setting.
Since the check for VMRootExec is already needed anyway, use the same to
check if using qubes.VMRootShell makes sense, as both changes were
introduced at the same time in core-agent-linux:
1c538af2 Use rpc-config for running qubes.VMRoot* services as root
563a9cfa Add qubes.VMRootExec service
This is more flexible method than hardcoding version check.
And add a test for this case.
Fixes: f38c1d4 "use qubes.VMRootExec/qubes.VMRootShell services when root needed"
Fixes QubesOS/qubes-issues#10590
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #467 +/- ##
==========================================
+ Coverage 76.65% 76.67% +0.02%
==========================================
Files 53 53
Lines 9407 9407
==========================================
+ Hits 7211 7213 +2
+ Misses 2196 2194 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Template imported from R4.2 already has qubes.VMRootShell service, but
it isn't really running as root by default. It's only R4.3+ when both
qubes.VMRootShell and qubes.VMRootExec got also force-user=root setting.
Since the check for VMRootExec is already needed anyway, use the same to
check if using qubes.VMRootShell makes sense, as both changes were
introduced at the same time in core-agent-linux:
This is more flexible method than hardcoding version check.
And add a test for this case.
Fixes: f38c1d4 "use qubes.VMRootExec/qubes.VMRootShell services when root needed"
Fixes QubesOS/qubes-issues#10590