tests: assertEquals -> assertEqual#615
Conversation
The former is removed in Python 3.13 QubesOS/qubes-issues#9402
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #615 +/- ##
==========================================
+ Coverage 69.32% 69.33% +0.01%
==========================================
Files 58 58
Lines 11953 11946 -7
==========================================
- Hits 8286 8283 -3
+ Misses 3667 3663 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024082316-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024070519-4.3&flavor=update
Failed tests120 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/105374#dependencies 8 fixed
Unstable testsDetails
|
Don't leave children, as cleanup_loop will (rightfully) detect it as a leak.
marmarek
force-pushed
the
update-f41
branch
3 times, most recently
from
1df301a to
be1dc05
Compare
Don't leak child processes after the test, even if they would terminate after a timeout anyway.
Include content of the selector map when it's non-empty, to ease finding what got leaked.
marmarek
force-pushed
the
update-f41
branch
2 times, most recently
from
065e78c to
7bc5ad7
Compare
Recent Thunderbird opens a message in a window no fitting on 1024x768 by default. This makes the attachment button off-screen so clicking it doesn't work. Fix it by resizing the window.
Python 3.12+ fixed server.wait_closed() to really wait for all the connections to terminate. This causes qubesd to hang on shutdown, as events connections were not closed. Python 3.13 introduces convenient server.close_clients() function to close all connections. There was a similar code in tests already - convert that to close_clients() call too. Fixes QubesOS/qubes-issues#9427
Python 3.13 adds automatic socket cleanup - specifically, a cleanup_socket parameter to loop.create_unix_server, and it defaults to True. Manual cleanup is not needed anymore.
3 participants
The former is removed in Python 3.13
QubesOS/qubes-issues#9402
Fixes QubesOS/qubes-issues#9429