Preload dispvm dom0 feat #684
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #684 +/- ##
==========================================
- Coverage 70.60% 70.41% -0.20%
==========================================
Files 61 61
Lines 12984 13327 +343
==========================================
+ Hits 9168 9384 +216
- Misses 3816 3943 +127
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ben-grande
force-pushed
the
preload-dispvm-dom0-feat
branch
4 times, most recently
from
a9fb929 to
0dfefdc
Compare
Is a disposable state, it runs on the background and awaits to intercept calls made to disposables of the same disposable template, having faster execution times. Information of the design choices is present in the DispVM class. To use them, set the number of allowed preloaded for each disposable template with the feature "preload-dispvm-max". In case there is not enough available memory, the maximum won't be preloaded at this instance, but will retry later on at any relevant event, such as a preloaded being used or a normal qube being requested while a preload can be created. GUI daemon requires a running qube to connect to the GUI agent in the qube, because of that, auto starting the preload mechanism only happens after a GUI login. Preloaded qubes are hidden from GUI applications until the qube itself is requested to be used. Any GUI application that allows opening applications on preloaded qubes before they are marked as used is considered a bug. Applications that autostart on the qube are shown before the qube has its state interrupted, it is also a bug but that can't be fixed easily. For: QubesOS/qubes-issues#1512 For: QubesOS/qubes-issues#9918
ben-grande
force-pushed
the
preload-dispvm-dom0-feat
branch
from
0dfefdc to
2be985a
Compare
Contributor
Author
|
The PR was closed automatically by Github due to rebase, The tooltip of the button
Please reopen. |
Member
|
Looks like you need open a new one... |
Member
|
or maybe I can now? |
Member
|
nope, the button is inactive... |
Contributor
Author
|
Not great, because I am rebasing on top of #660 everytime there is a commit squashed there... I will wait to open a new PR after that PR is merged so rebasing won't be necessary anymore. |
Contributor
Author
|
Successor: #686 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of #660
Mostly finished, except the deletion of the feature that needs to be adjusted on both ends (see TODOS). Didn't test yet.