Skip backup of undesirable preload feature#720
Conversation
ben-grande
force-pushed
the
preload-backup
branch
2 times, most recently
from
500e8fd to
73c42aa
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #720 +/- ##
==========================================
- Coverage 70.56% 70.44% -0.12%
==========================================
Files 61 61
Lines 13604 13574 -30
==========================================
- Hits 9599 9562 -37
- Misses 4005 4012 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ben-grande
force-pushed
the
preload-backup
branch
from
73c42aa to
ca79ddc
Compare
ben-grande
force-pushed
the
preload-backup
branch
from
ca79ddc to
7b9becb
Compare
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025082411-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025081011-4.3&flavor=update
Failed tests13 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/149225#dependencies 72 fixed
Unstable testsDetailsPerformance TestsPerformance degradation:19 performance degradations
Remaining performance tests:155 tests
|
3 participants
For: QubesOS/qubes-issues#1512
Tested the backup and restoration manually, no integ tests yet. If backing up a disposable template without this PR, an error message appears during the restoration:
Even if the preload-dispvm-max feature was restored before the preload-dispvm, it would fail with another message of disposable doesn't exist or not descendant of the disposable template. Later on, the qubes are preloaded according to the max.
It doesn't fail the backup though, but removing this error message is better and also still preloads the max when the restoration completes.