Integer comparison on qube volume size#774
Closed
ben-grande wants to merge 1 commit intoQubesOS:mainfrom
Closed
Conversation
ben-grande
force-pushed
the
preload-fix-vol-size
branch
from
52f4dda to
2f313b3
Compare
32 tasks
Disposable size is integer and disposable template size is string. For: QubesOS/qubes-issues#1512 For: QubesOS/qubes-issues#10525 Fixes: QubesOS/qubes-issues#10572 For: QubesOS#771
ben-grande
force-pushed
the
preload-fix-vol-size
branch
from
2f313b3 to
fbb0c92
Compare
Contributor
Author
|
I clicked close by mistake... Edit: No, github automatically closed it and reopen button has "Branch was force-pushed or recreated", I don't know why it does that sometimes, I force-push a lot, but it doesn't allow reopening. I will create a new PR once I finish the integration tests. |
Contributor
Author
|
Superseded by #775 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For: QubesOS/qubes-issues#1512
For: QubesOS/qubes-issues#10525
Fixes: QubesOS/qubes-issues#10572
For: #771