Skip to content

Fix deferred netvm detachment #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marmarek merged 1 commit into from
Feb 5, 2026
+4 −5
Merged

Fix deferred netvm detachment #779

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions qubes/vm/mix/net.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,11 +455,10 @@ def detach_network(self):
if not self.is_running():
raise qubes.exc.QubesVMNotRunningError(self)
deferred_from = self.features.get("deferred-netvm-original", None)
if self.netvm is None:
if deferred_from is not None:
raise qubes.exc.QubesVMError(
self, "netvm should not be {}".format(self.netvm)
)
if self.netvm is None and deferred_from is None:
raise qubes.exc.QubesVMError(
self, "netvm should not be {}".format(self.netvm)
)

# Properties extracted from libvirt_domain to support deferred netvm.
root = lxml.etree.fromstring(self.libvirt_domain.XMLDesc())
Expand Down