qvm-copy: support --ignore-symlinks and honor --#529
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #529 +/- ##
=======================================
Coverage 70.57% 70.57%
=======================================
Files 3 3
Lines 469 469
=======================================
Hits 331 331
Misses 138 138 ☔ View full report in Codecov by Sentry. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024110421-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024091704-4.3&flavor=update
Failed tests22 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/112766#dependencies 199 fixed
Unstable testsDetails
|
"--" was stripped from the arguments before being passed to qfile-agent, so "qvm-copy -- --ignore-symlinks" would ignore symlinks instead of copying a file named "--ignore-symlinks". To fix this problem, always pass "--" to qfile-agent, preceeded by --ignore-symlinks if necessary. This requires qfile-agent to honor -- as indicating end of options, so patch it to do that.
List the options and document -- as indicating end of options.
This improves consistency and is trivial to implement.
DemiMarie
force-pushed
the
copy-command-line-flags
branch
from
2ea4119 to
404ea26
Compare
3 participants
--was stripped from the arguments before being passed to qfile-agent, soqvm-copy -- --ignore-symlinkswould ignore symlinks instead of copying a file named--ignore-symlinks. To fix this problem, always pass--to qfile-agent, preceeded by--ignore-symlinksif necessary. This requires qfile-agent to honor--as indicating end of options, so patch it to do that.