tinyproxy: cleanup config and script by zpc0 · Pull Request #596 · QubesOS/qubes-core-agent-linux

zpc0 · 2025-07-05T06:38:08Z

Drop unused config.
Drop no longer needed wrapper.

Additional question:
I think 60s tinyproxy timeout is too long for system updates, because there are many mirror servers to use. Should I add commit which reduces timeout to 5s or 10s?

3nprob · 2025-07-05T07:05:57Z

network/tinyproxy-wrapper

@@ -1,12 +0,0 @@
-#!/bin/bash
-
-if [ -e /usr/sbin/tinyproxy ]; then


/usr/sbin/tinyproxy stopped being used in Debian Buster. So dropping this by now should be fine.

QubesOS/qubes-issues#4929

0fd8da6

(Could even revert the command -v since the path should now be fixed and static?)

marmarek · 2025-07-06T01:27:15Z

Packages fail to build - makefile needs to be updated.

Upstream commit b935dc8 dropped these configs.

All distros (Fedora, Debian, Arch, Ubuntu) places tinyproxy under /usr/bin, so this wrapper is no longer needed.

zpc0 · 2025-07-06T05:52:18Z

Packages fail to build - makefile needs to be updated.

Thanks. I updated Makefile.

codecov · 2025-07-06T06:12:06Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.10%. Comparing base (e5d626b) to head (e067ae3).
Report is 6 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #596   +/-   ##
=======================================
  Coverage   71.10%   71.10%           
=======================================
  Files           3        3           
  Lines         481      481           
=======================================
  Hits          342      342           
  Misses        139      139

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

qubesos-bot · 2025-07-07T16:57:31Z

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025071015-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025061004-4.3&flavor=update

system_tests_whonix
- whonixcheck: fail (unknown)
  Whonixcheck for anon-whonix failed...
- whonixcheck: wait_serial (wait serial expected)
  # wait_serial expected: qr/TBvsr-\d+-/...
- whonixcheck: Failed (test died + timed out)
  # Test died: command 'qvm-run -ap whonix-gateway-17 'LC_ALL=C whon...
system_tests_suspend
- suspend: wait_serial (wait serial expected)
  # wait_serial expected: qr/wG5VX-\d+-/...
- suspend: Failed (test died + timed out)
  # Test died: command 'qvm-run -ap sys-whonix 'LC_ALL=C whonixcheck ...
system_tests_guivm_vnc_gui_interactive
- update_guivm: Failed (test died)
  # Test died: command 'curl --form upload=@qubesctl-sys-gui.log --fo...
system_tests_qwt_win10_seamless@hw13
- windows_clipboard_and_filecopy: unnamed test (unknown)
- windows_clipboard_and_filecopy: Failed (test died)
  # Test died: no candidate needle with tag(s) 'menu-vm-windows-Explo...
system_tests_qwt_win11@hw13
- windows_clipboard_and_filecopy: unnamed test (unknown)
- windows_clipboard_and_filecopy: Failed (test died)
  # Test died: no candidate needle with tag(s) 'windows-Explorer-new'...
system_tests_audio@hw1
- TC_20_AudioVM_Pulse_whonix-workstation-17: test_252_audio_playback_audiovm_switch_hvm (error)
  qubes.exc.QubesVMError: Cannot connect to qrexec agent for 60 secon...

Failed tests

14 failures

system_tests_whonix
- whonixcheck: fail (unknown)
  Whonixcheck for anon-whonix failed...
- whonixcheck: wait_serial (wait serial expected)
  # wait_serial expected: qr/TBvsr-\d+-/...
- whonixcheck: Failed (test died + timed out)
  # Test died: command 'qvm-run -ap whonix-gateway-17 'LC_ALL=C whon...
system_tests_suspend
- suspend: wait_serial (wait serial expected)
  # wait_serial expected: qr/wG5VX-\d+-/...
- suspend: Failed (test died + timed out)
  # Test died: command 'qvm-run -ap sys-whonix 'LC_ALL=C whonixcheck ...
system_tests_extra
- TC_00_QVCTest_whonix-workstation-17: test_010_screenshare (failure)
  AssertionError: 1 != 0 : Timeout waiting for /dev/video0 in test-in...
system_tests_kde_gui_interactive
- gui_keyboard_layout: wait_serial (wait serial expected)
  # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...
- gui_keyboard_layout: Failed (test died)
  # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...
system_tests_guivm_vnc_gui_interactive
- update_guivm: Failed (test died)
  # Test died: command 'curl --form upload=@qubesctl-sys-gui.log --fo...
system_tests_qwt_win10_seamless@hw13
- windows_clipboard_and_filecopy: unnamed test (unknown)
- windows_clipboard_and_filecopy: Failed (test died)
  # Test died: no candidate needle with tag(s) 'menu-vm-windows-Explo...
system_tests_qwt_win11@hw13
- windows_clipboard_and_filecopy: unnamed test (unknown)
- windows_clipboard_and_filecopy: Failed (test died)
  # Test died: no candidate needle with tag(s) 'windows-Explorer-new'...
system_tests_audio@hw1
- TC_20_AudioVM_Pulse_whonix-workstation-17: test_252_audio_playback_audiovm_switch_hvm (error)
  qubes.exc.QubesVMError: Cannot connect to qrexec agent for 60 secon...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/142375#dependencies

10 fixed

system_tests_splitgpg
- TC_10_Thunderbird_whonix-workstation-17: test_000_send_receive_default (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
- TC_10_Thunderbird_whonix-workstation-17: test_010_send_receive_inline_signed_only (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
- TC_10_Thunderbird_whonix-workstation-17: test_020_send_receive_inline_with_attachment (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
system_tests_extra
- TC_10_Thunderbird_whonix-workstation-17: test_000_send_receive_default (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
- TC_10_Thunderbird_whonix-workstation-17: test_010_send_receive_inline_signed_only (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
- TC_10_Thunderbird_whonix-workstation-17: test_020_send_receive_inline_with_attachment (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
system_tests_guivm_vnc_gui_interactive
- simple_gui_apps: unnamed test (unknown)
- simple_gui_apps: Failed (test died)
  # Test died: no candidate needle with tag(s) 'vm-settings-applicati...
system_tests_audio
- TC_20_AudioVM_Pulse_debian-12-xfce: test_252_audio_playback_audiovm_switch_hvm (failure)
  AssertionError: only silence detected, no useful audio data
- TC_20_AudioVM_Pulse_whonix-workstation-17: test_225_audio_rec_unmuted_hvm (failure)
  AssertionError: too short audio, expected 10s, got 7.95233560090703...

Unstable tests

Details

Performance Tests

Performance degradation:

12 performance degradations

debian-12-xfce_exec-data-simplex: 73.84 🔺 ( previous job: 65.51, degradation: 112.72%)
debian-12-xfce_exec-data-duplex-root: 83.89 🔺 ( previous job: 70.01, degradation: 119.83%)
whonix-workstation-17_exec-data-duplex-root: 99.32 🔺 ( previous job: 86.00, degradation: 115.49%)
dom0_root_seq1m_q8t1_read 3:read_bandwidth_kb: 160417.00 :small_red_triangle: ( previous job: 289982.00, degradation: 55.32%)
dom0_root_seq1m_q8t1_write 3:write_bandwidth_kb: 83277.00 :small_red_triangle: ( previous job: 101988.00, degradation: 81.65%)
dom0_root_seq1m_q1t1_write 3:write_bandwidth_kb: 17017.00 :small_red_triangle: ( previous job: 32696.00, degradation: 52.05%)
dom0_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 711.00 :small_red_triangle: ( previous job: 17102.00, degradation: 4.16%)
dom0_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 646.00 :small_red_triangle: ( previous job: 1091.00, degradation: 59.21%)
dom0_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 7313.00 :small_red_triangle: ( previous job: 11086.00, degradation: 65.97%)
dom0_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 1450.00 :small_red_triangle: ( previous job: 1840.00, degradation: 78.80%)
dom0_varlibqubes_seq1m_q1t1_write 3:write_bandwidth_kb: 145847.00 :small_red_triangle: ( previous job: 167872.00, degradation: 86.88%)
dom0_varlibqubes_rnd4k_q32t1_write 3:write_bandwidth_kb: 6755.00 :small_red_triangle: ( previous job: 8874.00, degradation: 76.12%)

Remaining performance tests:

60 tests

debian-12-xfce_exec: 6.92 🟢 ( previous job: 8.63, improvement: 80.16%)
debian-12-xfce_exec-root: 30.95 🔺 ( previous job: 29.44, degradation: 105.15%)
debian-12-xfce_socket: 8.50 🔺 ( previous job: 8.50, degradation: 100.02%)
debian-12-xfce_socket-root: 8.17 🟢 ( previous job: 8.31, improvement: 98.22%)
debian-12-xfce_exec-data-duplex: 71.89 🟢 ( previous job: 73.55, improvement: 97.75%)
debian-12-xfce_socket-data-duplex: 154.94 🟢 ( previous job: 161.35, improvement: 96.03%)
fedora-42-xfce_exec: 9.15
fedora-42-xfce_exec-root: 58.96
fedora-42-xfce_socket: 8.60
fedora-42-xfce_socket-root: 8.21
fedora-42-xfce_exec-data-simplex: 67.58
fedora-42-xfce_exec-data-duplex: 75.86
fedora-42-xfce_exec-data-duplex-root: 99.49
fedora-42-xfce_socket-data-duplex: 146.52
whonix-gateway-17_exec: 6.25 🟢 ( previous job: 7.34, improvement: 85.14%)
whonix-gateway-17_exec-root: 39.61 🔺 ( previous job: 39.57, degradation: 100.10%)
whonix-gateway-17_socket: 7.98 🔺 ( previous job: 7.85, degradation: 101.65%)
whonix-gateway-17_socket-root: 7.08 🟢 ( previous job: 7.89, improvement: 89.68%)
whonix-gateway-17_exec-data-simplex: 73.55 🟢 ( previous job: 77.76, improvement: 94.58%)
whonix-gateway-17_exec-data-duplex: 81.79 🔺 ( previous job: 78.39, degradation: 104.34%)
whonix-gateway-17_exec-data-duplex-root: 91.37 🔺 ( previous job: 90.74, degradation: 100.69%)
whonix-gateway-17_socket-data-duplex: 170.03 🔺 ( previous job: 161.95, degradation: 104.99%)
whonix-workstation-17_exec: 7.93 🟢 ( previous job: 8.27, improvement: 95.84%)
whonix-workstation-17_exec-root: 54.70 🟢 ( previous job: 57.61, improvement: 94.96%)
whonix-workstation-17_socket: 8.51 🟢 ( previous job: 8.97, improvement: 94.92%)
whonix-workstation-17_socket-root: 8.23 🟢 ( previous job: 9.46, improvement: 87.01%)
whonix-workstation-17_exec-data-simplex: 58.17 🟢 ( previous job: 74.54, improvement: 78.05%)
whonix-workstation-17_exec-data-duplex: 78.00 🔺 ( previous job: 74.84, degradation: 104.23%)
whonix-workstation-17_socket-data-duplex: 163.04 🔺 ( previous job: 160.20, degradation: 101.77%)
dom0_root_seq1m_q1t1_read 3:read_bandwidth_kb: 78108.00 :green_circle: ( previous job: 14284.00, improvement: 546.82%)
dom0_varlibqubes_seq1m_q8t1_read 3:read_bandwidth_kb: 475760.00 :green_circle: ( previous job: 289182.00, improvement: 164.52%)
dom0_varlibqubes_seq1m_q8t1_write 3:write_bandwidth_kb: 123287.00 :green_circle: ( previous job: 122848.00, improvement: 100.36%)
dom0_varlibqubes_seq1m_q1t1_read 3:read_bandwidth_kb: 444688.00 :green_circle: ( previous job: 433654.00, improvement: 102.54%)
dom0_varlibqubes_rnd4k_q32t1_read 3:read_bandwidth_kb: 104871.00 :small_red_triangle: ( previous job: 108760.00, degradation: 96.42%)
dom0_varlibqubes_rnd4k_q1t1_read 3:read_bandwidth_kb: 7854.00 :green_circle: ( previous job: 6356.00, improvement: 123.57%)
dom0_varlibqubes_rnd4k_q1t1_write 3:write_bandwidth_kb: 5000.00 :green_circle: ( previous job: 4420.00, improvement: 113.12%)
fedora-42-xfce_root_seq1m_q8t1_read 3:read_bandwidth_kb: 379506.00
fedora-42-xfce_root_seq1m_q8t1_write 3:write_bandwidth_kb: 144569.00
fedora-42-xfce_root_seq1m_q1t1_read 3:read_bandwidth_kb: 345039.00
fedora-42-xfce_root_seq1m_q1t1_write 3:write_bandwidth_kb: 62543.00
fedora-42-xfce_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 86398.00
fedora-42-xfce_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 3864.00
fedora-42-xfce_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 8560.00
fedora-42-xfce_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 1128.00
fedora-42-xfce_private_seq1m_q8t1_read 3:read_bandwidth_kb: 354368.00
fedora-42-xfce_private_seq1m_q8t1_write 3:write_bandwidth_kb: 108459.00
fedora-42-xfce_private_seq1m_q1t1_read 3:read_bandwidth_kb: 281875.00
fedora-42-xfce_private_seq1m_q1t1_write 3:write_bandwidth_kb: 85043.00
fedora-42-xfce_private_rnd4k_q32t1_read 3:read_bandwidth_kb: 87211.00
fedora-42-xfce_private_rnd4k_q32t1_write 3:write_bandwidth_kb: 3111.00
fedora-42-xfce_private_rnd4k_q1t1_read 3:read_bandwidth_kb: 8861.00
fedora-42-xfce_private_rnd4k_q1t1_write 3:write_bandwidth_kb: 707.00
fedora-42-xfce_volatile_seq1m_q8t1_read 3:read_bandwidth_kb: 404387.00
fedora-42-xfce_volatile_seq1m_q8t1_write 3:write_bandwidth_kb: 115044.00
fedora-42-xfce_volatile_seq1m_q1t1_read 3:read_bandwidth_kb: 326862.00
fedora-42-xfce_volatile_seq1m_q1t1_write 3:write_bandwidth_kb: 11108.00
fedora-42-xfce_volatile_rnd4k_q32t1_read 3:read_bandwidth_kb: 76688.00
fedora-42-xfce_volatile_rnd4k_q32t1_write 3:write_bandwidth_kb: 2536.00
fedora-42-xfce_volatile_rnd4k_q1t1_read 3:read_bandwidth_kb: 8553.00
fedora-42-xfce_volatile_rnd4k_q1t1_write 3:write_bandwidth_kb: 1386.00

marmarek · 2025-07-10T11:28:34Z

I think 60s tinyproxy timeout is too long for system updates, because there are many mirror servers to use. Should I add commit which reduces timeout to 5s or 10s?

That may impact updates via Tor - sometimes it's pretty slow. Apt/Dnf already have their own timeouts (and they do that a bit smarter - not just absolute value, but also based on progress). So, I'd prefer to keep the proxy one high.

installed at same path on debian/redhat/fedora. - follow-up to QubesOS#596 - QubesOS#157 - QubesOS#155

zpc0 · 2025-07-15T10:25:46Z

I think 60s tinyproxy timeout is too long for system updates, because there are many mirror servers to use. Should I add commit which reduces timeout to 5s or 10s?

That may impact updates via Tor - sometimes it's pretty slow. Apt/Dnf already have their own timeouts (and they do that a bit smarter - not just absolute value, but also based on progress). So, I'd prefer to keep the proxy one high.

Thank you for comment. I agree with your decision.

3nprob reviewed Jul 5, 2025

View reviewed changes

zpc0 added 2 commits July 6, 2025 14:48

tinyproxy: drop unused configs

b637f14

Upstream commit b935dc8 dropped these configs.

tinyproxy: drop no longer needed wrapper

e067ae3

All distros (Fedora, Debian, Arch, Ubuntu) places tinyproxy under /usr/bin, so this wrapper is no longer needed.

zpc0 force-pushed the tinyproxy branch from 20d4e95 to e067ae3 Compare July 6, 2025 05:50

marmarek added the openqa-pending label Jul 6, 2025

This was referenced Jul 7, 2025

Add Arch packaging QubesOS/qubes-core-admin-client#332

Open

Improve device category description QubesOS/qubes-core-admin-client#362

Merged

Add Virtual DNS for IPv6 (#558) QubesOS/qubes-core-admin#695

Draft

tests: DNS over IPv6 QubesOS/qubes-core-admin#696

Open

marmarek approved these changes Jul 10, 2025

View reviewed changes

qubesos-bot mentioned this pull request Jul 10, 2025

Update PV drivers QubesOS/qubes-vmm-xen-windows-pvdrivers#4

Open

marmarek merged commit 83842c3 into QubesOS:main Jul 10, 2025
4 of 5 checks passed

3nprob pushed a commit to 3nprob/qubes-core-agent-linux that referenced this pull request Jul 10, 2025

tinyproxy: hardcode /usr/bin/tinyproxy path

1dc30a1

installed at same path on debian/redhat/fedora. - follow-up to QubesOS#596 - QubesOS#157 - QubesOS#155

3nprob mentioned this pull request Jul 10, 2025

tinyproxy: hardcode /usr/bin/tinyproxy path #598

Merged

zpc0 deleted the tinyproxy branch July 14, 2025 09:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

tinyproxy: cleanup config and script#596

tinyproxy: cleanup config and script#596
marmarek merged 2 commits intoQubesOS:mainfrom
zpc0:tinyproxy

zpc0 commented Jul 5, 2025

Uh oh!

3nprob Jul 5, 2025 •

edited

Loading

Uh oh!

marmarek commented Jul 6, 2025 •

edited

Loading

Uh oh!

zpc0 commented Jul 6, 2025

Uh oh!

codecov bot commented Jul 6, 2025 •

edited

Loading

Uh oh!

qubesos-bot commented Jul 7, 2025 •

edited

Loading

Uh oh!

marmarek commented Jul 10, 2025

Uh oh!

Uh oh!

zpc0 commented Jul 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		@@ -1,12 +0,0 @@
		#!/bin/bash

		if [ -e /usr/sbin/tinyproxy ]; then

Uh oh!

Conversation

zpc0 commented Jul 5, 2025

Uh oh!

3nprob Jul 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

marmarek commented Jul 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zpc0 commented Jul 6, 2025

Uh oh!

codecov bot commented Jul 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

qubesos-bot commented Jul 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

OpenQA test summary

New failures, excluding unstable

Failed tests

Fixed failures

Unstable tests

Performance Tests

Performance degradation:

Remaining performance tests:

Uh oh!

marmarek commented Jul 10, 2025

Uh oh!

Uh oh!

zpc0 commented Jul 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

3nprob Jul 5, 2025 •

edited

Loading

marmarek commented Jul 6, 2025 •

edited

Loading

codecov bot commented Jul 6, 2025 •

edited

Loading

qubesos-bot commented Jul 7, 2025 •

edited

Loading