Skip to content

Fix protocol version negotiation on agent reconnect#195

Merged
marmarek merged 1 commit intoQubesOS:mainfrom
marmarek:protocol-on-reconnect
Mar 28, 2025
Merged

Fix protocol version negotiation on agent reconnect#195
marmarek merged 1 commit intoQubesOS:mainfrom
marmarek:protocol-on-reconnect

Conversation

@marmarek
Copy link
Copy Markdown
Member

When qrexec-agent reconnect save newly negotiated protocol version. The
agent might have been just updated.

Found while testing #182

When qrexec-agent reconnect save newly negotiated protocol version. The
agent might have been just updated.
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.82%. Comparing base (f0ab26a) to head (27f7ac0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
- Coverage   78.86%   78.82%   -0.05%     
==========================================
  Files          55       55              
  Lines       10151    10152       +1     
==========================================
- Hits         8006     8002       -4     
- Misses       2145     2150       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@qubesos-bot
Copy link
Copy Markdown

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025032720-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025031804-4.3&flavor=update

  • system_tests_qrexec

    • TC_00_Qrexec_debian-12-xfce: test_065_qrexec_exit_code_vm (failure)
      ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^... AssertionError: b'125\n' != b'0\n'
  • system_tests_kde_gui_interactive

    • gui_filecopy: unnamed test (unknown)
    • gui_filecopy: Failed (test died)
      # Test died: no candidate needle with tag(s) 'files-test-file' matc...
  • system_tests_qwt_win10@hw13

    • windows_install: Failed (test died)
      # Test died: command './install.sh' failed at /usr/lib/os-autoinst/...
  • system_tests_qwt_win10_seamless@hw13

    • windows_install: Failed (test died)
      # Test died: command './install.sh' failed at /usr/lib/os-autoinst/...
  • system_tests_qwt_win11@hw13

    • windows_install: Failed (test died)
      # Test died: command './install.sh' failed at /usr/lib/os-autoinst/...
  • system_tests_suspend@hw1

    • suspend: unnamed test (unknown)
    • suspend: Failed (test died)
      # Test died: no candidate needle with tag(s) 'SUSPEND-FAILED' match...

Failed tests

8 failures
  • system_tests_qrexec

    • TC_00_Qrexec_debian-12-xfce: test_065_qrexec_exit_code_vm (failure)
      ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^... AssertionError: b'125\n' != b'0\n'
  • system_tests_kde_gui_interactive

    • gui_filecopy: unnamed test (unknown)
    • gui_filecopy: Failed (test died)
      # Test died: no candidate needle with tag(s) 'files-test-file' matc...
  • system_tests_qwt_win10@hw13

    • windows_install: Failed (test died)
      # Test died: command './install.sh' failed at /usr/lib/os-autoinst/...
  • system_tests_qwt_win10_seamless@hw13

    • windows_install: Failed (test died)
      # Test died: command './install.sh' failed at /usr/lib/os-autoinst/...
  • system_tests_qwt_win11@hw13

    • windows_install: Failed (test died)
      # Test died: command './install.sh' failed at /usr/lib/os-autoinst/...
  • system_tests_suspend@hw1

    • suspend: unnamed test (unknown)
    • suspend: Failed (test died)
      # Test died: no candidate needle with tag(s) 'SUSPEND-FAILED' match...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/132953#dependencies

14 fixed
  • system_tests_whonix

    • whonixcheck: fail (unknown)
      Whonixcheck for sys-whonix failed...

    • whonixcheck: unnamed test (unknown)

  • system_tests_suspend

    • suspend: unnamed test (unknown)
    • suspend: Failed (test died)
      # Test died: no candidate needle with tag(s) 'SUSPEND-FAILED' match...
  • system_tests_basic_vm_qrexec_gui

  • system_tests_qrexec

  • system_tests_kde_gui_interactive

    • clipboard_and_web: unnamed test (unknown)

    • clipboard_and_web: Failed (test died)
      # Test died: no candidate needle with tag(s) 'qubes-website' matche...

    • clipboard_and_web: wait_serial (wait serial expected)
      # wait_serial expected: "lspci; echo 2E8vz-\$?-"...

  • system_tests_guivm_vnc_gui_interactive

    • gui_filecopy: unnamed test (unknown)
    • gui_filecopy: Failed (test died)
      # Test died: no candidate needle with tag(s) 'files-work' matched...
  • system_tests_whonix@hw7

    • whonixcheck: fail (unknown)
      Whonixcheck for sys-whonix failed...

    • whonixcheck: unnamed test (unknown)

  • system_tests_audio

Unstable tests

Details

Performance Tests

Performance degradation:

11 performance degradations
  • whonix-gateway-17_socket: 8.45 :small_red_triangle_up: ( previous job: 7.24, degradation: 116.85%)
  • whonix-workstation-17_socket: 9.11 :small_red_triangle_up: ( previous job: 8.19, degradation: 111.20%)
  • dom0_root_seq1m_q8t1_read 3:read_bandwidth_kb: 398395.00 :small_red_triangle_up: ( previous job: 446963.00, degradation: 89.13%)
  • dom0_root_seq1m_q1t1_read 3:read_bandwidth_kb: 83547.00 :small_red_triangle_up: ( previous job: 294295.00, degradation: 28.39%)
  • dom0_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 31880.00 :small_red_triangle_up: ( previous job: 79803.00, degradation: 39.95%)
  • dom0_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 1022.00 :small_red_triangle_up: ( previous job: 4826.00, degradation: 21.18%)
  • dom0_varlibqubes_rnd4k_q1t1_write 3:write_bandwidth_kb: 2397.00 :small_red_triangle_up: ( previous job: 4903.00, degradation: 48.89%)
  • fedora-41-xfce_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 2203.00 :small_red_triangle_up: ( previous job: 3599.00, degradation: 61.21%)
  • fedora-41-xfce_private_seq1m_q1t1_read 3:read_bandwidth_kb: 292734.00 :small_red_triangle_up: ( previous job: 334687.00, degradation: 87.47%)
  • fedora-41-xfce_private_rnd4k_q1t1_write 3:write_bandwidth_kb: 1002.00 :small_red_triangle_up: ( previous job: 1130.00, degradation: 88.67%)
  • fedora-41-xfce_volatile_rnd4k_q32t1_write 3:write_bandwidth_kb: 3350.00 :small_red_triangle_up: ( previous job: 5672.00, degradation: 59.06%)

Remaining performance tests:

61 tests
  • debian-12-xfce_exec: 7.80 :small_red_triangle_up: ( previous job: 7.12, degradation: 109.52%)
  • debian-12-xfce_exec-root: 30.01 :small_red_triangle_up: ( previous job: 28.65, degradation: 104.74%)
  • debian-12-xfce_socket: 8.31 🟢 ( previous job: 8.60, improvement: 96.64%)
  • debian-12-xfce_socket-root: 8.73 :small_red_triangle_up: ( previous job: 8.52, degradation: 102.38%)
  • debian-12-xfce_exec-data-simplex: 65.75 🟢 ( previous job: 71.62, improvement: 91.80%)
  • debian-12-xfce_exec-data-duplex: 72.46 :small_red_triangle_up: ( previous job: 70.34, degradation: 103.01%)
  • debian-12-xfce_exec-data-duplex-root: 86.90 :small_red_triangle_up: ( previous job: 82.72, degradation: 105.06%)
  • debian-12-xfce_socket-data-duplex: 159.87 :small_red_triangle_up: ( previous job: 156.96, degradation: 101.86%)
  • fedora-41-xfce_exec: 9.39 :small_red_triangle_up: ( previous job: 9.27, degradation: 101.35%)
  • fedora-41-xfce_exec-root: 62.57 :small_red_triangle_up: ( previous job: 61.51, degradation: 101.73%)
  • fedora-41-xfce_socket: 9.15 :small_red_triangle_up: ( previous job: 8.63, degradation: 106.09%)
  • fedora-41-xfce_socket-root: 8.90 :small_red_triangle_up: ( previous job: 8.71, degradation: 102.17%)
  • fedora-41-xfce_exec-data-simplex: 63.83 🟢 ( previous job: 75.53, improvement: 84.50%)
  • fedora-41-xfce_exec-data-duplex: 73.67 :small_red_triangle_up: ( previous job: 71.56, degradation: 102.95%)
  • fedora-41-xfce_exec-data-duplex-root: 108.12 🟢 ( previous job: 109.13, improvement: 99.08%)
  • fedora-41-xfce_socket-data-duplex: 142.08 🟢 ( previous job: 150.61, improvement: 94.34%)
  • whonix-gateway-17_exec: 7.21 :small_red_triangle_up: ( previous job: 6.82, degradation: 105.78%)
  • whonix-gateway-17_exec-root: 41.06 :small_red_triangle_up: ( previous job: 40.43, degradation: 101.54%)
  • whonix-gateway-17_socket-root: 8.13 :small_red_triangle_up: ( previous job: 7.65, degradation: 106.26%)
  • whonix-gateway-17_exec-data-simplex: 78.54 :small_red_triangle_up: ( previous job: 78.32, degradation: 100.28%)
  • whonix-gateway-17_exec-data-duplex: 75.59 🟢 ( previous job: 76.65, improvement: 98.62%)
  • whonix-gateway-17_exec-data-duplex-root: 94.70 :small_red_triangle_up: ( previous job: 88.52, degradation: 106.97%)
  • whonix-gateway-17_socket-data-duplex: 172.45 :small_red_triangle_up: ( previous job: 171.76, degradation: 100.40%)
  • whonix-workstation-17_exec: 8.41 :small_red_triangle_up: ( previous job: 7.67, degradation: 109.60%)
  • whonix-workstation-17_exec-root: 56.85 🟢 ( previous job: 58.26, improvement: 97.58%)
  • whonix-workstation-17_socket-root: 8.77 :small_red_triangle_up: ( previous job: 8.13, degradation: 107.85%)
  • whonix-workstation-17_exec-data-simplex: 68.99 🟢 ( previous job: 74.99, improvement: 91.99%)
  • whonix-workstation-17_exec-data-duplex: 74.46 :small_red_triangle_up: ( previous job: 72.71, degradation: 102.40%)
  • whonix-workstation-17_exec-data-duplex-root: 102.74 :small_red_triangle_up: ( previous job: 99.82, degradation: 102.92%)
  • whonix-workstation-17_socket-data-duplex: 162.62 🟢 ( previous job: 169.50, improvement: 95.94%)
  • dom0_root_seq1m_q8t1_write 3:write_bandwidth_kb: 143939.00 :green_circle: ( previous job: 129298.00, improvement: 111.32%)
  • dom0_root_seq1m_q1t1_write 3:write_bandwidth_kb: 97016.00 :green_circle: ( previous job: 95454.00, improvement: 101.64%)
  • dom0_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 5715.00 :small_red_triangle_up: ( previous job: 6149.00, degradation: 92.94%)
  • dom0_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 12046.00 :green_circle: ( previous job: 10795.00, improvement: 111.59%)
  • dom0_varlibqubes_seq1m_q8t1_read 3:read_bandwidth_kb: 519097.00 :green_circle: ( previous job: 382273.00, improvement: 135.79%)
  • dom0_varlibqubes_seq1m_q8t1_write 3:write_bandwidth_kb: 266406.00 :green_circle: ( previous job: 250795.00, improvement: 106.22%)
  • dom0_varlibqubes_seq1m_q1t1_read 3:read_bandwidth_kb: 442064.00 :green_circle: ( previous job: 437636.00, improvement: 101.01%)
  • dom0_varlibqubes_seq1m_q1t1_write 3:write_bandwidth_kb: 203492.00 :green_circle: ( previous job: 184752.00, improvement: 110.14%)
  • dom0_varlibqubes_rnd4k_q32t1_read 3:read_bandwidth_kb: 103049.00 :green_circle: ( previous job: 62195.00, improvement: 165.69%)
  • dom0_varlibqubes_rnd4k_q32t1_write 3:write_bandwidth_kb: 7289.00 :green_circle: ( previous job: 6479.00, improvement: 112.50%)
  • dom0_varlibqubes_rnd4k_q1t1_read 3:read_bandwidth_kb: 8118.00 :green_circle: ( previous job: 7669.00, improvement: 105.85%)
  • fedora-41-xfce_root_seq1m_q8t1_read 3:read_bandwidth_kb: 402215.00 :green_circle: ( previous job: 368309.00, improvement: 109.21%)
  • fedora-41-xfce_root_seq1m_q8t1_write 3:write_bandwidth_kb: 312541.00 :green_circle: ( previous job: 162081.00, improvement: 192.83%)
  • fedora-41-xfce_root_seq1m_q1t1_read 3:read_bandwidth_kb: 331827.00 :green_circle: ( previous job: 318716.00, improvement: 104.11%)
  • fedora-41-xfce_root_seq1m_q1t1_write 3:write_bandwidth_kb: 87205.00 :small_red_triangle_up: ( previous job: 87940.00, degradation: 99.16%)
  • fedora-41-xfce_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 91403.00 :green_circle: ( previous job: 82694.00, improvement: 110.53%)
  • fedora-41-xfce_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 7855.00 :small_red_triangle_up: ( previous job: 8485.00, degradation: 92.58%)
  • fedora-41-xfce_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 778.00 :green_circle: ( previous job: 542.00, improvement: 143.54%)
  • fedora-41-xfce_private_seq1m_q8t1_read 3:read_bandwidth_kb: 364088.00 :small_red_triangle_up: ( previous job: 373957.00, degradation: 97.36%)
  • fedora-41-xfce_private_seq1m_q8t1_write 3:write_bandwidth_kb: 178308.00 :green_circle: ( previous job: 170062.00, improvement: 104.85%)
  • fedora-41-xfce_private_seq1m_q1t1_write 3:write_bandwidth_kb: 66368.00 :green_circle: ( previous job: 61534.00, improvement: 107.86%)
  • fedora-41-xfce_private_rnd4k_q32t1_read 3:read_bandwidth_kb: 85132.00 :green_circle: ( previous job: 80283.00, improvement: 106.04%)
  • fedora-41-xfce_private_rnd4k_q32t1_write 3:write_bandwidth_kb: 4200.00 :green_circle: ( previous job: 2215.00, improvement: 189.62%)
  • fedora-41-xfce_private_rnd4k_q1t1_read 3:read_bandwidth_kb: 8641.00 :green_circle: ( previous job: 7540.00, improvement: 114.60%)
  • fedora-41-xfce_volatile_seq1m_q8t1_read 3:read_bandwidth_kb: 345722.00 :small_red_triangle_up: ( previous job: 369868.00, degradation: 93.47%)
  • fedora-41-xfce_volatile_seq1m_q8t1_write 3:write_bandwidth_kb: 163107.00 :small_red_triangle_up: ( previous job: 179949.00, degradation: 90.64%)
  • fedora-41-xfce_volatile_seq1m_q1t1_read 3:read_bandwidth_kb: 312541.00 :small_red_triangle_up: ( previous job: 324737.00, degradation: 96.24%)
  • fedora-41-xfce_volatile_seq1m_q1t1_write 3:write_bandwidth_kb: 53669.00 :green_circle: ( previous job: 17567.00, improvement: 305.51%)
  • fedora-41-xfce_volatile_rnd4k_q32t1_read 3:read_bandwidth_kb: 76692.00 :small_red_triangle_up: ( previous job: 79021.00, degradation: 97.05%)
  • fedora-41-xfce_volatile_rnd4k_q1t1_read 3:read_bandwidth_kb: 8116.00 :green_circle: ( previous job: 7867.00, improvement: 103.17%)
  • fedora-41-xfce_volatile_rnd4k_q1t1_write 3:write_bandwidth_kb: 1839.00 :small_red_triangle_up: ( previous job: 1953.00, degradation: 94.16%)

@marmarek marmarek merged commit 27f7ac0 into QubesOS:main Mar 28, 2025
4 of 5 checks passed
@marmarek marmarek deleted the protocol-on-reconnect branch February 11, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants