Show progress bar after loading CSS theme#231
Merged
marmarek merged 1 commit intoQubesOS:mainfrom Nov 23, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #231 +/- ##
==========================================
- Coverage 93.58% 93.56% -0.02%
==========================================
Files 57 57
Lines 10903 10901 -2
==========================================
- Hits 10204 10200 -4
- Misses 699 701 +2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
This was referenced Nov 12, 2024
Merged
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024112303-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024111705-4.3&flavor=update
Failed tests8 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/119126#dependencies 3 fixed
Unstable testsDetails
|
This was referenced Nov 12, 2024
marmarta
approved these changes
Nov 18, 2024
This was referenced Nov 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the progress bar is shown before loading the application CSS theme, it looks like a graphical glitch for around 744ms on my HP Elitebook 820 system. Until the next call to
update_progressandGtk.main_iteration_doloop (picture below).But if the progress bar is shown and updated right after loading the CSS theme, it is much prettier.