Merge #258 and #262 #266

marmarek · 2025-06-10T22:19:00Z

No description provided.

Less clicks, more clarity, better accessibility. Also minor changes to icon loading.

- configurable devices_denied - configurable auto-attach and required attachment This is just the Global Config part. requires QubesOS/qubes-core-admin-client#355

adjust black options to stop enforcing 80 characters, instead default to 88.

For: QubesOS/qubes-issues#1512

codecov · 2025-06-10T22:40:54Z

Codecov Report

Attention: Patch coverage is 94.54471% with 133 lines in your changes missing coverage. Please review.

Project coverage is 92.93%. Comparing base (387c2c8) to head (fc738db).
Report is 11 commits behind head on main.

Files with missing lines	Patch %	Lines
qubes_config/global_config/device_attachments.py	89.48%	59 Missing ⚠️
qubes_config/tests/test_device_attachments.py	95.93%	25 Missing ⚠️
qubes_config/tests/test_device_blocks.py	92.97%	17 Missing ⚠️
qubes_config/global_config/basics_handler.py	83.60%	10 Missing ⚠️
qubes_config/global_config/device_blocks.py	98.57%	4 Missing ⚠️
qubes_config/global_config/device_widgets.py	97.75%	4 Missing ⚠️
qubes_config/global_config/policy_rules.py	60.00%	2 Missing ⚠️
qui/updater/progress_page.py	85.71%	2 Missing ⚠️
qubes_config/global_config/global_config.py	90.00%	1 Missing ⚠️
qubes_config/global_config/policy_handler.py	92.30%	1 Missing ⚠️
... and 8 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #266      +/-   ##
==========================================
+ Coverage   92.71%   92.93%   +0.21%     
==========================================
  Files          59       64       +5     
  Lines       11304    13121    +1817     
==========================================
+ Hits        10481    12194    +1713     
- Misses        823      927     +104

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

qubesos-bot · 2025-06-11T10:48:57Z

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025061202-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025061004-4.3&flavor=update

system_tests_qwt_win10@hw13
- windows_install: wait_serial (wait serial expected)
  # wait_serial expected: qr/LDWI1-\d+-/...
- windows_install: Failed (test died + timed out)
  # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...
system_tests_qwt_win10_seamless@hw13
- windows_clipboard_and_filecopy: unnamed test (unknown)
- windows_clipboard_and_filecopy: Failed (test died)
  # Test died: no candidate needle with tag(s) 'windows-Edge-address-...
system_tests_dispvm
- TC_20_DispVM_debian-12-xfce: test_015_dvm_run_preload_race_more (failure)
  AssertionError: unexpected selector map entries: {5: SelectorKey(fi...
- TC_20_DispVM_debian-12-xfce: test_017_dvm_run_preload_autostart (failure)
  AssertionError: unexpected selector map entries: {5: SelectorKey(fi...
- TC_20_DispVM_fedora-41-xfce: test_015_dvm_run_preload_race_more (failure)
  AssertionError: unexpected selector map entries: {5: SelectorKey(fi...
- TC_20_DispVM_fedora-41-xfce: test_017_dvm_run_preload_autostart (failure)
  AssertionError: unexpected selector map entries: {5: SelectorKey(fi...
- TC_20_DispVM_whonix-workstation-17: test_015_dvm_run_preload_race_more (failure)
  AssertionError: unexpected selector map entries: {5: SelectorKey(fi...
- TC_20_DispVM_whonix-workstation-17: test_017_dvm_run_preload_autostart (failure)
  AssertionError: unexpected selector map entries: {5: SelectorKey(fi...

Failed tests

13 failures

system_tests_qwt_win10@hw13
- windows_install: wait_serial (wait serial expected)
  # wait_serial expected: qr/LDWI1-\d+-/...
- windows_install: Failed (test died + timed out)
  # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...
system_tests_qwt_win10_seamless@hw13
- windows_clipboard_and_filecopy: unnamed test (unknown)
- windows_clipboard_and_filecopy: Failed (test died)
  # Test died: no candidate needle with tag(s) 'windows-Edge-address-...
system_tests_extra
- TC_00_QVCTest_whonix-workstation-17: test_010_screenshare (failure)
  AssertionError: 1 != 0 : Timeout waiting for /dev/video0 in test-in...
system_tests_dispvm
- TC_20_DispVM_debian-12-xfce: test_015_dvm_run_preload_race_more (failure)
  AssertionError: unexpected selector map entries: {5: SelectorKey(fi...
- TC_20_DispVM_debian-12-xfce: test_017_dvm_run_preload_autostart (failure)
  AssertionError: unexpected selector map entries: {5: SelectorKey(fi...
- TC_20_DispVM_fedora-41-xfce: test_015_dvm_run_preload_race_more (failure)
  AssertionError: unexpected selector map entries: {5: SelectorKey(fi...
- TC_20_DispVM_fedora-41-xfce: test_017_dvm_run_preload_autostart (failure)
  AssertionError: unexpected selector map entries: {5: SelectorKey(fi...
- TC_20_DispVM_whonix-workstation-17: test_015_dvm_run_preload_race_more (failure)
  AssertionError: unexpected selector map entries: {5: SelectorKey(fi...
- TC_20_DispVM_whonix-workstation-17: test_017_dvm_run_preload_autostart (failure)
  AssertionError: unexpected selector map entries: {5: SelectorKey(fi...
system_tests_kde_gui_interactive
- gui_keyboard_layout: wait_serial (wait serial expected)
  # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...
- gui_keyboard_layout: Failed (test died)
  # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/142375#dependencies

10 fixed

system_tests_splitgpg
- TC_10_Thunderbird_whonix-workstation-17: test_000_send_receive_default (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
- TC_10_Thunderbird_whonix-workstation-17: test_010_send_receive_inline_signed_only (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
- TC_10_Thunderbird_whonix-workstation-17: test_020_send_receive_inline_with_attachment (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
system_tests_extra
- TC_10_Thunderbird_whonix-workstation-17: test_000_send_receive_default (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
- TC_10_Thunderbird_whonix-workstation-17: test_010_send_receive_inline_signed_only (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
- TC_10_Thunderbird_whonix-workstation-17: test_020_send_receive_inline_with_attachment (failure)
  dogtail.tree.SearchError: descendent of [application | Thunderbird]...
system_tests_audio
- TC_20_AudioVM_Pulse_debian-12-xfce: test_252_audio_playback_audiovm_switch_hvm (failure)
  AssertionError: only silence detected, no useful audio data
- TC_20_AudioVM_Pulse_whonix-workstation-17: test_225_audio_rec_unmuted_hvm (failure)
  AssertionError: too short audio, expected 10s, got 7.95233560090703...
system_tests_guivm_vnc_gui_interactive
- simple_gui_apps: unnamed test (unknown)
- simple_gui_apps: Failed (test died)
  # Test died: no candidate needle with tag(s) 'vm-settings-applicati...

Unstable tests

Details

Performance Tests

Performance degradation:

8 performance degradations

debian-12-xfce_exec-data-duplex-root: 81.91 🔺 ( previous job: 70.01, degradation: 117.00%)
fedora-41-xfce_exec-data-duplex: 76.19 🔺 ( previous job: 68.34, degradation: 111.49%)
dom0_varlibqubes_rnd4k_q32t1_write 3:write_bandwidth_kb: 5986.00 :small_red_triangle: ( previous job: 8874.00, degradation: 67.46%)
fedora-41-xfce_root_seq1m_q8t1_write 3:write_bandwidth_kb: 90052.00 :small_red_triangle: ( previous job: 138008.00, degradation: 65.25%)
fedora-41-xfce_root_seq1m_q1t1_write 3:write_bandwidth_kb: 34038.00 :small_red_triangle: ( previous job: 75708.00, degradation: 44.96%)
fedora-41-xfce_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 1462.00 :small_red_triangle: ( previous job: 3547.00, degradation: 41.22%)
fedora-41-xfce_private_seq1m_q1t1_write 3:write_bandwidth_kb: 36658.00 :small_red_triangle: ( previous job: 43760.00, degradation: 83.77%)
fedora-41-xfce_volatile_rnd4k_q1t1_write 3:write_bandwidth_kb: 1295.00 :small_red_triangle: ( previous job: 1713.00, degradation: 75.60%)

Remaining performance tests:

64 tests

debian-12-xfce_exec: 6.75 🟢 ( previous job: 8.63, improvement: 78.23%)
debian-12-xfce_exec-root: 29.39 🟢 ( previous job: 29.44, improvement: 99.83%)
debian-12-xfce_socket: 7.83 🟢 ( previous job: 8.50, improvement: 92.13%)
debian-12-xfce_socket-root: 8.39 🔺 ( previous job: 8.31, degradation: 100.96%)
debian-12-xfce_exec-data-simplex: 67.50 🔺 ( previous job: 65.51, degradation: 103.03%)
debian-12-xfce_exec-data-duplex: 74.27 🔺 ( previous job: 73.55, degradation: 100.99%)
debian-12-xfce_socket-data-duplex: 165.15 🔺 ( previous job: 161.35, degradation: 102.35%)
fedora-41-xfce_exec: 9.07 🟢 ( previous job: 9.30, improvement: 97.47%)
fedora-41-xfce_exec-root: 60.60 🔺 ( previous job: 60.59, degradation: 100.01%)
fedora-41-xfce_socket: 8.70 🔺 ( previous job: 8.48, degradation: 102.62%)
fedora-41-xfce_socket-root: 8.38 🟢 ( previous job: 8.81, improvement: 95.03%)
fedora-41-xfce_exec-data-simplex: 65.50 🟢 ( previous job: 76.90, improvement: 85.18%)
fedora-41-xfce_exec-data-duplex-root: 111.42 🔺 ( previous job: 109.83, degradation: 101.45%)
fedora-41-xfce_socket-data-duplex: 139.80 🟢 ( previous job: 156.23, improvement: 89.49%)
whonix-gateway-17_exec: 7.68 🔺 ( previous job: 7.34, degradation: 104.57%)
whonix-gateway-17_exec-root: 37.51 🟢 ( previous job: 39.57, improvement: 94.78%)
whonix-gateway-17_socket: 7.64 🟢 ( previous job: 7.85, improvement: 97.26%)
whonix-gateway-17_socket-root: 7.17 🟢 ( previous job: 7.89, improvement: 90.85%)
whonix-gateway-17_exec-data-simplex: 64.82 🟢 ( previous job: 77.76, improvement: 83.35%)
whonix-gateway-17_exec-data-duplex: 81.66 🔺 ( previous job: 78.39, degradation: 104.18%)
whonix-gateway-17_exec-data-duplex-root: 97.93 🔺 ( previous job: 90.74, degradation: 107.92%)
whonix-gateway-17_socket-data-duplex: 175.20 🔺 ( previous job: 161.95, degradation: 108.18%)
whonix-workstation-17_exec: 8.28 🔺 ( previous job: 8.27, degradation: 100.01%)
whonix-workstation-17_exec-root: 52.60 🟢 ( previous job: 57.61, improvement: 91.31%)
whonix-workstation-17_socket: 8.33 🟢 ( previous job: 8.97, improvement: 92.90%)
whonix-workstation-17_socket-root: 9.44 🟢 ( previous job: 9.46, improvement: 99.83%)
whonix-workstation-17_exec-data-simplex: 74.51 🟢 ( previous job: 74.54, improvement: 99.96%)
whonix-workstation-17_exec-data-duplex: 73.05 🟢 ( previous job: 74.84, improvement: 97.60%)
whonix-workstation-17_exec-data-duplex-root: 86.09 🔺 ( previous job: 86.00, degradation: 100.10%)
whonix-workstation-17_socket-data-duplex: 144.13 🟢 ( previous job: 160.20, improvement: 89.97%)
dom0_root_seq1m_q8t1_read 3:read_bandwidth_kb: 336621.00 :green_circle: ( previous job: 289982.00, improvement: 116.08%)
dom0_root_seq1m_q8t1_write 3:write_bandwidth_kb: 110816.00 :green_circle: ( previous job: 101988.00, improvement: 108.66%)
dom0_root_seq1m_q1t1_read 3:read_bandwidth_kb: 218180.00 :green_circle: ( previous job: 14284.00, improvement: 1527.44%)
dom0_root_seq1m_q1t1_write 3:write_bandwidth_kb: 99386.00 :green_circle: ( previous job: 32696.00, improvement: 303.97%)
dom0_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 17430.00 :green_circle: ( previous job: 17102.00, improvement: 101.92%)
dom0_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 6053.00 :green_circle: ( previous job: 1091.00, improvement: 554.81%)
dom0_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 11668.00 :green_circle: ( previous job: 11086.00, improvement: 105.25%)
dom0_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 3570.00 :green_circle: ( previous job: 1840.00, improvement: 194.02%)
dom0_varlibqubes_seq1m_q8t1_read 3:read_bandwidth_kb: 464177.00 :green_circle: ( previous job: 289182.00, improvement: 160.51%)
dom0_varlibqubes_seq1m_q8t1_write 3:write_bandwidth_kb: 131957.00 :green_circle: ( previous job: 122848.00, improvement: 107.41%)
dom0_varlibqubes_seq1m_q1t1_read 3:read_bandwidth_kb: 435998.00 :green_circle: ( previous job: 433654.00, improvement: 100.54%)
dom0_varlibqubes_seq1m_q1t1_write 3:write_bandwidth_kb: 167467.00 :small_red_triangle: ( previous job: 167872.00, degradation: 99.76%)
dom0_varlibqubes_rnd4k_q32t1_read 3:read_bandwidth_kb: 108460.00 :small_red_triangle: ( previous job: 108760.00, degradation: 99.72%)
dom0_varlibqubes_rnd4k_q1t1_read 3:read_bandwidth_kb: 7682.00 :green_circle: ( previous job: 6356.00, improvement: 120.86%)
dom0_varlibqubes_rnd4k_q1t1_write 3:write_bandwidth_kb: 4847.00 :green_circle: ( previous job: 4420.00, improvement: 109.66%)
fedora-41-xfce_root_seq1m_q8t1_read 3:read_bandwidth_kb: 372231.00 :small_red_triangle: ( previous job: 401292.00, degradation: 92.76%)
fedora-41-xfce_root_seq1m_q1t1_read 3:read_bandwidth_kb: 325442.00 :green_circle: ( previous job: 306332.00, improvement: 106.24%)
fedora-41-xfce_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 92539.00 :green_circle: ( previous job: 88110.00, improvement: 105.03%)
fedora-41-xfce_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 8263.00 :green_circle: ( previous job: 7675.00, improvement: 107.66%)
fedora-41-xfce_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 1796.00 :green_circle: ( previous job: 950.00, improvement: 189.05%)
fedora-41-xfce_private_seq1m_q8t1_read 3:read_bandwidth_kb: 399762.00 :small_red_triangle: ( previous job: 404699.00, degradation: 98.78%)
fedora-41-xfce_private_seq1m_q8t1_write 3:write_bandwidth_kb: 122704.00 :green_circle: ( previous job: 99783.00, improvement: 122.97%)
fedora-41-xfce_private_seq1m_q1t1_read 3:read_bandwidth_kb: 353770.00 :green_circle: ( previous job: 330572.00, improvement: 107.02%)
fedora-41-xfce_private_rnd4k_q32t1_read 3:read_bandwidth_kb: 93675.00 :green_circle: ( previous job: 86107.00, improvement: 108.79%)
fedora-41-xfce_private_rnd4k_q32t1_write 3:write_bandwidth_kb: 4410.00 :green_circle: ( previous job: 1209.00, improvement: 364.76%)
fedora-41-xfce_private_rnd4k_q1t1_read 3:read_bandwidth_kb: 8497.00 :small_red_triangle: ( previous job: 8908.00, degradation: 95.39%)
fedora-41-xfce_private_rnd4k_q1t1_write 3:write_bandwidth_kb: 1063.00 :green_circle: ( previous job: 653.00, improvement: 162.79%)
fedora-41-xfce_volatile_seq1m_q8t1_read 3:read_bandwidth_kb: 371967.00 :green_circle: ( previous job: 335115.00, improvement: 111.00%)
fedora-41-xfce_volatile_seq1m_q8t1_write 3:write_bandwidth_kb: 111738.00 :green_circle: ( previous job: 88088.00, improvement: 126.85%)
fedora-41-xfce_volatile_seq1m_q1t1_read 3:read_bandwidth_kb: 352225.00 :green_circle: ( previous job: 323135.00, improvement: 109.00%)
fedora-41-xfce_volatile_seq1m_q1t1_write 3:write_bandwidth_kb: 60728.00 :small_red_triangle: ( previous job: 62556.00, degradation: 97.08%)
fedora-41-xfce_volatile_rnd4k_q32t1_read 3:read_bandwidth_kb: 83576.00 :small_red_triangle: ( previous job: 86131.00, degradation: 97.03%)
fedora-41-xfce_volatile_rnd4k_q32t1_write 3:write_bandwidth_kb: 4934.00 :green_circle: ( previous job: 2636.00, improvement: 187.18%)
fedora-41-xfce_volatile_rnd4k_q1t1_read 3:read_bandwidth_kb: 8129.00 :green_circle: ( previous job: 8052.00, improvement: 100.96%)

* origin/pr/258: Last round of review fixes Fix updater tests for new mocks pacify black Review fixes Add config for device attachments to Global Config Change global config tests to use Mock Qubes API Changed VM flowbox for improved UX Pull request description: - improved dark mode - use Mock API for tests - add config for device attachments to Global Config, in particular - devices denied can be configured - auto-attach, ask-to-attach and required auto-attach can be configured requires QubesOS/qubes-core-admin-client#355

marmarta and others added 7 commits May 22, 2025 00:21

Changed VM flowbox for improved UX

b0e92d4

Less clicks, more clarity, better accessibility. Also minor changes to icon loading.

Change global config tests to use Mock Qubes API

921446d

Add config for device attachments to Global Config

568f3d7

- configurable devices_denied - configurable auto-attach and required attachment This is just the Global Config part. requires QubesOS/qubes-core-admin-client#355

Review fixes

6076bd4

pacify black

23e70bb

adjust black options to stop enforcing 80 characters, instead default to 88.

Fix updater tests for new mocks

b237806

Add preload disposable setting to global config

c18c9b0

For: QubesOS/qubes-issues#1512

marmarek added the openqa-pending label Jun 10, 2025

marmarek force-pushed the pr-264-merge branch from 31450a7 to c5b7df8 Compare June 11, 2025 17:06

marmarta and others added 2 commits June 11, 2025 22:28

Last round of review fixes

b445fbd

marmarek force-pushed the pr-264-merge branch from c5b7df8 to fc738db Compare June 12, 2025 00:41

qubesos-bot mentioned this pull request Jun 12, 2025

Remove '$env' after it's loaded into environment QubesOS/qubes-gui-agent-linux#234

Merged

marmarek closed this Jun 12, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Merge #258 and #262 #266

Merge #258 and #262 #266

Uh oh!

marmarek commented Jun 10, 2025

Uh oh!

codecov bot commented Jun 10, 2025 •

edited

Loading

Uh oh!

qubesos-bot commented Jun 11, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Merge #258 and #262 #266

Merge #258 and #262 #266

Uh oh!

Conversation

marmarek commented Jun 10, 2025

Uh oh!

codecov bot commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

qubesos-bot commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

OpenQA test summary

New failures, excluding unstable

Failed tests

Fixed failures

Unstable tests

Performance Tests

Performance degradation:

Remaining performance tests:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Jun 10, 2025 •

edited

Loading

qubesos-bot commented Jun 11, 2025 •

edited

Loading