Hide internal qubes from device attachment

[ben-grande]

For: QubesOS/qubes-issues#1512

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.91%. Comparing base (1867ded) to head (a2a4519).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #271      +/-   ##
==========================================
- Coverage   92.93%   92.91%   -0.02%     
==========================================
  Files          64       64              
  Lines       13063    13063              
==========================================
- Hits        12140    12138       -2     
- Misses        923      925       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ben-grande]

Just for clarification, the vm_unpaused is needed because when the internal feature is deleted, the power state reported is Halted and therefore not attachable yet.

[qubesos-bot]

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025073017-4.3&flavor=pull-requests

Test run included the following:

• Add Arch packaging qubes-core-admin-client#332 (QubesOS/qubes-core-admin-client@40487bc)
• Hide internal qubes from device attachment #271 (a2a4519)
• Optimize SVG icons qubes-desktop-linux-menu#57 (QubesOS/qubes-desktop-linux-menu@aa4fdf6)
• pipewire: Use recommended driver and session priorities qubes-gui-agent-linux#242 (QubesOS/qubes-gui-agent-linux@1dcee27)
• Connect vchan to GUI domain instead of dom0 qubes-gui-agent-windows#7 (QubesOS/qubes-gui-agent-windows@b904d94)
• Ignore RemoteVM for now qubes-manager#398 (QubesOS/qubes-manager@679eff4)
• rpm: build and package debug hypervisor qubes-vmm-xen#170 (QubesOS/qubes-vmm-xen@24e16a6)

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025061004-4.3&flavor=update

• system_tests_audio@hw1

  • TC_20_AudioVM_PipeWire_fedora-42-xfce: test_260_audio_mic_enabled_switch_audiovm (failure)
    AssertionError: Failed to get mic attach/detach status!

• system_tests_qwt_win10@hw13

  • windows_install: wait_serial (wait serial expected)
    # wait_serial expected: qr/tKcyh-\d+-/...

  • windows_install: Failed (test died + timed out)
    # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

• system_tests_qwt_win11@hw13

  • windows_install: wait_serial (wait serial expected)
    # wait_serial expected: qr/qDqV_-\d+-/...

  • windows_install: Failed (test died + timed out)
    # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

• system_tests_whonix

  • whonixcheck: fail (unknown)
    Whonixcheck for anon-whonix failed...

  • whonixcheck: wait_serial (wait serial expected)
    # wait_serial expected: qr/TBvsr-\d+-/...

  • whonixcheck: Failed (test died + timed out)
    # Test died: command 'qvm-run -ap whonix-gateway-17 'LC_ALL=C whon...

• system_tests_guivm_gui_interactive

  • guivm_manager: unnamed test (unknown)
  • guivm_manager: Failed (test died)
    # Test died: no candidate needle with tag(s) 'vm-settings-applicati...

• system_tests_dispvm

  • TC_20_DispVM_debian-12-xfce: test_017_preload_autostart (failure)
    AssertionError: Lists differ: ['disp7965'] != []

  • TC_20_DispVM_fedora-42-xfce: test_017_preload_autostart (failure)
    AssertionError: Lists differ: ['disp331'] != []

  • TC_20_DispVM_whonix-workstation-17: test_017_preload_autostart (failure)
    AssertionError: Lists differ: ['disp6926'] != []

  • TC_20_DispVM_whonix-workstation-17: test_030_edit_file (failure + cleanup)
    AssertionError: Timeout while waiting for disp[0-9]* window to show

  • TC_20_DispVM_whonix-workstation-17: test_100_open_in_dispvm (failure + cleanup)
    AssertionError: Timeout while waiting for disp[0-9]* window to show

• system_tests_guivm_vnc_gui_interactive

  • guivm_manager: unnamed test (unknown)
  • guivm_manager: Failed (test died)
    # Test died: no candidate needle with tag(s) 'qubes-qube-manager' m...

• system_tests_basic_vm_qrexec_gui_ext4

  • switch_pool: Failed (test died)
    # Test died: command 'printf "label: gpt\n,,L" | sfdisk /dev/sdb' f...

• system_tests_qwt_win10_seamless@hw13

  • windows_install: wait_serial (wait serial expected)
    # wait_serial expected: qr/4E4Ei-\d+-/...

  • windows_install: Failed (test died + timed out)
    # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

Failed tests

22 failures

• system_tests_audio@hw1

  • TC_20_AudioVM_PipeWire_fedora-42-xfce: test_260_audio_mic_enabled_switch_audiovm (failure)
    AssertionError: Failed to get mic attach/detach status!

• system_tests_qwt_win10@hw13

  • windows_install: wait_serial (wait serial expected)
    # wait_serial expected: qr/tKcyh-\d+-/...

  • windows_install: Failed (test died + timed out)
    # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

• system_tests_qwt_win11@hw13

  • windows_install: wait_serial (wait serial expected)
    # wait_serial expected: qr/qDqV_-\d+-/...

  • windows_install: Failed (test died + timed out)
    # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

• system_tests_whonix

  • whonixcheck: fail (unknown)
    Whonixcheck for anon-whonix failed...

  • whonixcheck: wait_serial (wait serial expected)
    # wait_serial expected: qr/TBvsr-\d+-/...

  • whonixcheck: Failed (test died + timed out)
    # Test died: command 'qvm-run -ap whonix-gateway-17 'LC_ALL=C whon...

• system_tests_guivm_gui_interactive

  • guivm_manager: unnamed test (unknown)
  • guivm_manager: Failed (test died)
    # Test died: no candidate needle with tag(s) 'vm-settings-applicati...

• system_tests_dispvm

  • TC_20_DispVM_debian-12-xfce: test_017_preload_autostart (failure)
    AssertionError: Lists differ: ['disp7965'] != []

  • TC_20_DispVM_fedora-42-xfce: test_017_preload_autostart (failure)
    AssertionError: Lists differ: ['disp331'] != []

  • TC_20_DispVM_whonix-workstation-17: test_017_preload_autostart (failure)
    AssertionError: Lists differ: ['disp6926'] != []

  • TC_20_DispVM_whonix-workstation-17: test_030_edit_file (failure + cleanup)
    AssertionError: Timeout while waiting for disp[0-9]* window to show

  • TC_20_DispVM_whonix-workstation-17: test_100_open_in_dispvm (failure + cleanup)
    AssertionError: Timeout while waiting for disp[0-9]* window to show

• system_tests_kde_gui_interactive

  • gui_keyboard_layout: wait_serial (wait serial expected)
    # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

  • gui_keyboard_layout: Failed (test died)
    # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...

• system_tests_guivm_vnc_gui_interactive

  • guivm_manager: unnamed test (unknown)
  • guivm_manager: Failed (test died)
    # Test died: no candidate needle with tag(s) 'qubes-qube-manager' m...

• system_tests_basic_vm_qrexec_gui_ext4

  • switch_pool: Failed (test died)
    # Test died: command 'printf "label: gpt\n,,L" | sfdisk /dev/sdb' f...

• system_tests_qwt_win10_seamless@hw13

  • windows_install: wait_serial (wait serial expected)
    # wait_serial expected: qr/4E4Ei-\d+-/...

  • windows_install: Failed (test died + timed out)
    # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/142375#dependencies

11 fixed

• system_tests_splitgpg

  • TC_10_Thunderbird_whonix-workstation-17: test_000_send_receive_default (failure)
    dogtail.tree.SearchError: descendent of [application | Thunderbird]...

  • TC_10_Thunderbird_whonix-workstation-17: test_010_send_receive_inline_signed_only (failure)
    dogtail.tree.SearchError: descendent of [application | Thunderbird]...

  • TC_10_Thunderbird_whonix-workstation-17: test_020_send_receive_inline_with_attachment (failure)
    dogtail.tree.SearchError: descendent of [application | Thunderbird]...

• system_tests_extra

  • TC_10_Thunderbird_whonix-workstation-17: test_000_send_receive_default (failure)
    dogtail.tree.SearchError: descendent of [application | Thunderbird]...

  • TC_10_Thunderbird_whonix-workstation-17: test_010_send_receive_inline_signed_only (failure)
    dogtail.tree.SearchError: descendent of [application | Thunderbird]...

  • TC_10_Thunderbird_whonix-workstation-17: test_020_send_receive_inline_with_attachment (failure)
    dogtail.tree.SearchError: descendent of [application | Thunderbird]...

  • TC_00_QVCTest_whonix-workstation-17: test_010_screenshare (failure)
    AssertionError: 1 != 0 : Timeout waiting for /dev/video0 in test-in...

• system_tests_guivm_vnc_gui_interactive

  • simple_gui_apps: unnamed test (unknown)
  • simple_gui_apps: Failed (test died)
    # Test died: no candidate needle with tag(s) 'vm-settings-applicati...

• system_tests_audio

  • TC_20_AudioVM_Pulse_debian-12-xfce: test_252_audio_playback_audiovm_switch_hvm (failure)
    AssertionError: only silence detected, no useful audio data

  • TC_20_AudioVM_Pulse_whonix-workstation-17: test_225_audio_rec_unmuted_hvm (failure)
    AssertionError: too short audio, expected 10s, got 7.95233560090703...

Unstable tests

Details

Performance Tests

Performance degradation:

8 performance degradations

• debian-12-xfce_socket-root: 9.38 🔺 ( previous job: 8.31, degradation: 112.84%)
• debian-12-xfce_exec-data-duplex-root: 89.21 🔺 ( previous job: 70.01, degradation: 127.42%)
• whonix-gateway-17_socket: 8.81 🔺 ( previous job: 7.85, degradation: 112.15%)
• whonix-workstation-17_exec-data-duplex-root: 98.34 🔺 ( previous job: 86.00, degradation: 114.35%)
• dom0_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 11221.00 :small_red_triangle: ( previous job: 17102.00, degradation: 65.61%)
• dom0_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 545.00 :small_red_triangle: ( previous job: 1091.00, degradation: 49.95%)
• dom0_varlibqubes_rnd4k_q32t1_write 3:write_bandwidth_kb: 6930.00 :small_red_triangle: ( previous job: 8874.00, degradation: 78.09%)
• dom0_varlibqubes_rnd4k_q1t1_write 3:write_bandwidth_kb: 3667.00 :small_red_triangle: ( previous job: 4420.00, degradation: 82.96%)

Remaining performance tests:

64 tests

• debian-12-xfce_exec: 7.10 🟢 ( previous job: 8.63, improvement: 82.25%)
• debian-12-xfce_exec-root: 29.04 🟢 ( previous job: 29.44, improvement: 98.66%)
• debian-12-xfce_socket: 7.68 🟢 ( previous job: 8.50, improvement: 90.36%)
• debian-12-xfce_exec-data-simplex: 69.24 🔺 ( previous job: 65.51, degradation: 105.69%)
• debian-12-xfce_exec-data-duplex: 73.08 🟢 ( previous job: 73.55, improvement: 99.37%)
• debian-12-xfce_socket-data-duplex: 162.35 🔺 ( previous job: 161.35, degradation: 100.62%)
• fedora-42-xfce_exec: 9.25
• fedora-42-xfce_exec-root: 61.31
• fedora-42-xfce_socket: 9.12
• fedora-42-xfce_socket-root: 8.21
• fedora-42-xfce_exec-data-simplex: 62.66
• fedora-42-xfce_exec-data-duplex: 68.38
• fedora-42-xfce_exec-data-duplex-root: 95.68
• fedora-42-xfce_socket-data-duplex: 136.75
• whonix-gateway-17_exec: 8.00 🔺 ( previous job: 7.34, degradation: 109.01%)
• whonix-gateway-17_exec-root: 41.96 🔺 ( previous job: 39.57, degradation: 106.03%)
• whonix-gateway-17_socket-root: 7.15 🟢 ( previous job: 7.89, improvement: 90.56%)
• whonix-gateway-17_exec-data-simplex: 74.72 🟢 ( previous job: 77.76, improvement: 96.09%)
• whonix-gateway-17_exec-data-duplex: 83.22 🔺 ( previous job: 78.39, degradation: 106.16%)
• whonix-gateway-17_exec-data-duplex-root: 98.72 🔺 ( previous job: 90.74, degradation: 108.79%)
• whonix-gateway-17_socket-data-duplex: 172.77 🔺 ( previous job: 161.95, degradation: 106.68%)
• whonix-workstation-17_exec: 8.32 🔺 ( previous job: 8.27, degradation: 100.57%)
• whonix-workstation-17_exec-root: 57.19 🟢 ( previous job: 57.61, improvement: 99.28%)
• whonix-workstation-17_socket: 8.65 🟢 ( previous job: 8.97, improvement: 96.45%)
• whonix-workstation-17_socket-root: 9.52 🔺 ( previous job: 9.46, degradation: 100.59%)
• whonix-workstation-17_exec-data-simplex: 68.53 🟢 ( previous job: 74.54, improvement: 91.94%)
• whonix-workstation-17_exec-data-duplex: 69.90 🟢 ( previous job: 74.84, improvement: 93.40%)
• whonix-workstation-17_socket-data-duplex: 158.91 🟢 ( previous job: 160.20, improvement: 99.20%)
• dom0_root_seq1m_q8t1_read 3:read_bandwidth_kb: 266068.00 :small_red_triangle: ( previous job: 289982.00, degradation: 91.75%)
• dom0_root_seq1m_q8t1_write 3:write_bandwidth_kb: 181625.00 :green_circle: ( previous job: 101988.00, improvement: 178.08%)
• dom0_root_seq1m_q1t1_read 3:read_bandwidth_kb: 72882.00 :green_circle: ( previous job: 14284.00, improvement: 510.24%)
• dom0_root_seq1m_q1t1_write 3:write_bandwidth_kb: 95956.00 :green_circle: ( previous job: 32696.00, improvement: 293.48%)
• dom0_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 12293.00 :green_circle: ( previous job: 11086.00, improvement: 110.89%)
• dom0_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 2180.00 :green_circle: ( previous job: 1840.00, improvement: 118.48%)
• dom0_varlibqubes_seq1m_q8t1_read 3:read_bandwidth_kb: 505094.00 :green_circle: ( previous job: 289182.00, improvement: 174.66%)
• dom0_varlibqubes_seq1m_q8t1_write 3:write_bandwidth_kb: 209547.00 :green_circle: ( previous job: 122848.00, improvement: 170.57%)
• dom0_varlibqubes_seq1m_q1t1_read 3:read_bandwidth_kb: 412338.00 :small_red_triangle: ( previous job: 433654.00, degradation: 95.08%)
• dom0_varlibqubes_seq1m_q1t1_write 3:write_bandwidth_kb: 185902.00 :green_circle: ( previous job: 167872.00, improvement: 110.74%)
• dom0_varlibqubes_rnd4k_q32t1_read 3:read_bandwidth_kb: 98559.00 :small_red_triangle: ( previous job: 108760.00, degradation: 90.62%)
• dom0_varlibqubes_rnd4k_q1t1_read 3:read_bandwidth_kb: 7125.00 :green_circle: ( previous job: 6356.00, improvement: 112.10%)
• fedora-42-xfce_root_seq1m_q8t1_read 3:read_bandwidth_kb: 392872.00
• fedora-42-xfce_root_seq1m_q8t1_write 3:write_bandwidth_kb: 258588.00
• fedora-42-xfce_root_seq1m_q1t1_read 3:read_bandwidth_kb: 282406.00
• fedora-42-xfce_root_seq1m_q1t1_write 3:write_bandwidth_kb: 84720.00
• fedora-42-xfce_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 89486.00
• fedora-42-xfce_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 2648.00
• fedora-42-xfce_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 8520.00
• fedora-42-xfce_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 1102.00
• fedora-42-xfce_private_seq1m_q8t1_read 3:read_bandwidth_kb: 320959.00
• fedora-42-xfce_private_seq1m_q8t1_write 3:write_bandwidth_kb: 250855.00
• fedora-42-xfce_private_seq1m_q1t1_read 3:read_bandwidth_kb: 251940.00
• fedora-42-xfce_private_seq1m_q1t1_write 3:write_bandwidth_kb: 105628.00
• fedora-42-xfce_private_rnd4k_q32t1_read 3:read_bandwidth_kb: 94602.00
• fedora-42-xfce_private_rnd4k_q32t1_write 3:write_bandwidth_kb: 4791.00
• fedora-42-xfce_private_rnd4k_q1t1_read 3:read_bandwidth_kb: 8550.00
• fedora-42-xfce_private_rnd4k_q1t1_write 3:write_bandwidth_kb: 635.00
• fedora-42-xfce_volatile_seq1m_q8t1_read 3:read_bandwidth_kb: 362829.00
• fedora-42-xfce_volatile_seq1m_q8t1_write 3:write_bandwidth_kb: 194115.00
• fedora-42-xfce_volatile_seq1m_q1t1_read 3:read_bandwidth_kb: 354248.00
• fedora-42-xfce_volatile_seq1m_q1t1_write 3:write_bandwidth_kb: 91844.00
• fedora-42-xfce_volatile_rnd4k_q32t1_read 3:read_bandwidth_kb: 81618.00
• fedora-42-xfce_volatile_rnd4k_q32t1_write 3:write_bandwidth_kb: 2130.00
• fedora-42-xfce_volatile_rnd4k_q1t1_read 3:read_bandwidth_kb: 8487.00
• fedora-42-xfce_volatile_rnd4k_q1t1_write 3:write_bandwidth_kb: 1849.00

[ben-grande]

https://openqa.qubes-os.org/tests/148309#step/qui_widgets_devices/8

[marmarta]

Just for clarification, the vm_unpaused is needed because when the internal feature is deleted, the power state reported is Halted and therefore not attachable yet.

....that is a truly arcane interaction, thank you for noticing this.