Disable trying to attach device to a blocked qube#287
Conversation
If a qube has a given device on the denied_devices blocklist, the widget will have this qube grayed-out with a "blocked by policy" message. fixes QubesOS/qubes-issues#10356
|
PipelineRetry |
|
PipelineRefresh |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #287 +/- ##
==========================================
- Coverage 93.00% 92.96% -0.04%
==========================================
Files 64 64
Lines 13286 13286
==========================================
- Hits 12356 12351 -5
- Misses 930 935 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025112313-4.3&flavor=pull-requests Test run included the following:
Upload failures
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025111104-4.3&flavor=update
Failed tests25 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/158999#dependencies 17 fixed
Unstable testsDetailsPerformance TestsPerformance degradation:21 performance degradations
Remaining performance tests:85 tests
|
|
Maybe those blocked should be sorted at the end, or even hidden completely? I'm thinking of a case, where you are allowed to attach a device only to 2-3 qubes, but you have ~15 running - in that case, it will be inconvenient to navigate the list. |
|
I feel like this would disturb people's muscle memory for where a qube is? |
|
And hidden is a bad idea because they would be confusing - why is the qube not available? A person might forget they blocked something or have it blocked by organizational policy. |
|
Ok, lets merge it as is for now, and maybe adjust later based on the feedback. |
If a qube has a given device on the denied_devices blocklist, the widget will have this qube grayed-out with a "blocked by policy" message.
fixes QubesOS/qubes-issues#10356