Handle oversized clipboard for GUI protocol 1.8#217
Conversation
alimirjamali
force-pushed
the
issue-9296
branch
4 times, most recently
from
014e99f to
533f47c
Compare
alimirjamali
force-pushed
the
issue-9296
branch
from
533f47c to
b4f6888
Compare
alimirjamali
force-pushed
the
issue-9296
branch
from
b4f6888 to
4f40c65
Compare
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024102523-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024091704-4.3&flavor=update
Failed tests16 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/112766#dependencies 201 fixed
Unstable testsDetails
|
alimirjamali
force-pushed
the
issue-9296
branch
from
a9df082 to
82c5c1e
Compare
|
@marmarek |
alimirjamali
force-pushed
the
issue-9296
branch
from
82c5c1e to
36040ec
Compare
|
PipelineRetryFailed |
The pipeline fails again. Most probably because merging the https://gitlab.com/QubesOS/qubes-gui-agent-linux/-/jobs/8144115759#L3094 |
|
CI still uses R4.2 here. Can you add a commit that switches it to R4.3 here? (just s/4.2/4.3/ in the .gitlab-ci.yml) |
Done. For both |
It is better now. checks, build and install unittest are green. The repro tests still fail. Is there anything else I can do here? |
|
reprotest fails with: looks like it still uses old gui-common... let me check |
|
PipelineRetry |
|
PipelineRetryFailed |
1 similar comment
|
PipelineRetryFailed |
alimirjamali
force-pushed
the
issue-9296
branch
from
d2a4f7a to
51acf98
Compare
alimirjamali
force-pushed
the
issue-9296
branch
from
79d4434 to
1d4a717
Compare
|
Some commits are mixed up - the CI one has bumping protocol version, and 1d4a717 has a fix to message length. |
Could I squash them all together to one commit? This PR is not as long as |
alimirjamali
force-pushed
the
issue-9296
branch
from
1d4a717 to
6634b03
Compare
|
CI switch should be IMO in separate commit, but others can be squashed together. |
If vmside clipboard is over the maximum limit, sending one byte over maximum limit should trigger inter-vm clipboard rejection instead of truncation. If vmside clipboard is over 256KiB (X11 INCR), send a warning message fixes: QubesOS/qubes-issues#9296 fixes: QubesOS/qubes-issues#5220
Bumping CI protocol version to support GUI protocol 1.8
alimirjamali
force-pushed
the
issue-9296
branch
from
6634b03 to
178df5e
Compare
alimirjamali
changed the title
Is it good now? |
|
Yes, now looks good :) |
3 participants
If vmside clipboard is over the maximum limit, sending one byte over maximum limit should trigger inter-vm clipboard rejection instead of truncation.
Fixes: QubesOS/qubes-issues#9296
Fixes: QubesOS/qubes-issues#5220