Skip to content

debian: fix installing qubes-guid as suid#168

Merged
marmarek merged 1 commit intoQubesOS:mainfrom
marmarek:debian-suid
Aug 7, 2025
Merged

debian: fix installing qubes-guid as suid#168
marmarek merged 1 commit intoQubesOS:mainfrom
marmarek:debian-suid

Conversation

@marmarek
Copy link
Member

@marmarek marmarek commented Aug 5, 2025

This is how it works on Fedora, so mirror the behavior in Debian package
too.
Technically it might be possible to avoid the suid, by adjusting at
least log dir permissions, and probably few more. But that's separate
change, unbreak Debian for now.

Use postinst script instead of packaging with desired permissions
already, because the qubes group doesn't exist at the package build
time.

QubesOS/qubes-issues#8841

This is how it works on Fedora, so mirror the behavior in Debian package
too.
Technically it might be possible to avoid the suid, by adjusting at
least log dir permissions, and probably few more. But that's separate
change, unbreak Debian for now.

Use postinst script instead of packaging with desired permissions
already, because the qubes group doesn't exist at the package build
time.

QubesOS/qubes-issues#8841
@qubesos-bot
Copy link

qubesos-bot commented Aug 6, 2025

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025080616-4.3&flavor=templates

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025061004-4.3&flavor=update

  • system_tests_pvgrub_salt_storage

    • TC_40_PVGrub_debian-13-minimal: test_000_standalone_vm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

    • TC_40_PVGrub_debian-13-minimal: test_001_standalone_vm_dracut (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

    • TC_40_PVGrub_debian-13-minimal: test_010_template_based_vm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

    • TC_40_PVGrub_debian-13-minimal: test_011_template_based_vm_dracut (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

    • TC_40_PVGrub_debian-13-xfce: test_000_standalone_vm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

    • TC_40_PVGrub_debian-13-xfce: test_001_standalone_vm_dracut (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

    • TC_40_PVGrub_debian-13-xfce: test_010_template_based_vm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

    • TC_40_PVGrub_debian-13-xfce: test_011_template_based_vm_dracut (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

  • system_tests_extra

    • TC_00_QVCTest_debian-13-minimal: test_010_screenshare (failure)
      AssertionError: 1 != 0 : Timeout waiting for /dev/video0 in test-in...

    • TC_00_QVCTest_debian-13-minimal: test_020_webcam (failure)
      AssertionError: 1 != 0 : Timeout waiting for /dev/video0 in test-in...

Failed tests

10 failures
  • system_tests_pvgrub_salt_storage

    • TC_40_PVGrub_debian-13-minimal: test_000_standalone_vm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

    • TC_40_PVGrub_debian-13-minimal: test_001_standalone_vm_dracut (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

    • TC_40_PVGrub_debian-13-minimal: test_010_template_based_vm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

    • TC_40_PVGrub_debian-13-minimal: test_011_template_based_vm_dracut (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

    • TC_40_PVGrub_debian-13-xfce: test_000_standalone_vm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

    • TC_40_PVGrub_debian-13-xfce: test_001_standalone_vm_dracut (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

    • TC_40_PVGrub_debian-13-xfce: test_010_template_based_vm (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

    • TC_40_PVGrub_debian-13-xfce: test_011_template_based_vm_dracut (error)
      qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

  • system_tests_extra

    • TC_00_QVCTest_debian-13-minimal: test_010_screenshare (failure)
      AssertionError: 1 != 0 : Timeout waiting for /dev/video0 in test-in...

    • TC_00_QVCTest_debian-13-minimal: test_020_webcam (failure)
      AssertionError: 1 != 0 : Timeout waiting for /dev/video0 in test-in...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/142375#dependencies

9 fixed

Unstable tests

Details

Performance Tests

Performance degradation:

No issues

Remaining performance tests:

No remaining performance tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants