Move meminfo-writer to /usr/bin

[marmarek]

There it a tendency to merge /usr/bin and /usr/sbin (replace the latter
with a symlink). This caused a few issues already, including SELinux
mislabeling (QubesOS/qubes-issues#9663), file install issues where
%_sbindir RPM macro points at /usr/bin, and now on in-place upgrade
systemd unit points at /usr/sbin/meminfo-writer that doesn't exist at
the upgrade time.

Since this merging happened on Fedora 42 now, and much earlier on
Archlinux too, simplify things by simply moving meminfo-writer to
/usr/bin and don't have any special cases for distributions with merged
/usr/sbin or not. The change isn't relevant for Debian (yet?) but also
shouldn't hurt either.

QubesOS/qubes-issues#9807

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.56%. Comparing base (6578e70) to head (e5fb601).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #123   +/-   ##
=======================================
  Coverage   60.56%   60.56%           
=======================================
  Files           6        6           
  Lines         951      951           
  Branches      104      104           
=======================================
  Hits          576      576           
  Misses        285      285           
  Partials       90       90           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[qubesos-bot]

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025030303-4.3-fedora&flavor=templates

Test run included the following:

• Adjust qvm.template_installed to use qvm-check qubes-mgmt-salt-dom0-qvm#32 (QubesOS/qubes-mgmt-salt-dom0-qvm@251fe86)
• Move all binaries from /usr/sbin to /usr/bin qubes-core-qubesdb#68 (QubesOS/qubes-core-qubesdb@658ce33)
• Changes related to F42 update qubes-core-agent-linux#557 (QubesOS/qubes-core-agent-linux@4aec5a0)
• Update packaging for Xfce 4.20 qubes-desktop-linux-xfce4-xfwm4#21 (QubesOS/qubes-desktop-linux-xfce4-xfwm4@2727428)
• Move meminfo-writer to /usr/bin #123 (e5fb601)

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025021804-4.3&flavor=update

• system_tests_basic_vm_qrexec_gui

  • TC_30_Gui_daemon: test_002_clipboard_200k_truncated (error)
    subprocess.CalledProcessError: Command 'cat .xsession-errors' retur...

• system_tests_pvgrub_salt_storage

  • TC_41_HVMGrub_fedora-42-xfce: test_000_standalone_vm (error)
    qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

  • TC_41_HVMGrub_fedora-42-xfce: test_010_template_based_vm (error)
    qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

  • TC_42_PVHGrub_fedora-42-xfce: test_000_standalone_vm (error)
    qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

  • TC_42_PVHGrub_fedora-42-xfce: test_010_template_based_vm (error)
    qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

• system_tests_network_updates

  • TC_00_Dom0Upgrade_fedora-42-xfce: test_001_update_check (failure)
    ^... AssertionError: '1' is not false

• system_tests_guivm_gui_interactive

  • simple_gui_apps: unnamed test (unknown)

  • simple_gui_apps: Failed (test died)
    # Test died: no candidate needle with tag(s) 'vm-settings-applicati...

  • simple_gui_apps: wait_serial (wait serial expected)
    # wait_serial expected: "lspci; echo 2E8vz-\$?-"...

  • simple_gui_apps: wait_serial (wait serial expected)
    # wait_serial expected: qr/2E8vz-\d+-/...

Failed tests

10 failures

• system_tests_basic_vm_qrexec_gui

  • TC_30_Gui_daemon: test_002_clipboard_200k_truncated (error)
    subprocess.CalledProcessError: Command 'cat .xsession-errors' retur...

• system_tests_pvgrub_salt_storage

  • TC_41_HVMGrub_fedora-42-xfce: test_000_standalone_vm (error)
    qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

  • TC_41_HVMGrub_fedora-42-xfce: test_010_template_based_vm (error)
    qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

  • TC_42_PVHGrub_fedora-42-xfce: test_000_standalone_vm (error)
    qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

  • TC_42_PVHGrub_fedora-42-xfce: test_010_template_based_vm (error)
    qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...

• system_tests_network_updates

  • TC_00_Dom0Upgrade_fedora-42-xfce: test_001_update_check (failure)
    ^... AssertionError: '1' is not false

• system_tests_guivm_gui_interactive

  • simple_gui_apps: unnamed test (unknown)

  • simple_gui_apps: Failed (test died)
    # Test died: no candidate needle with tag(s) 'vm-settings-applicati...

  • simple_gui_apps: wait_serial (wait serial expected)
    # wait_serial expected: "lspci; echo 2E8vz-\$?-"...

  • simple_gui_apps: wait_serial (wait serial expected)
    # wait_serial expected: qr/2E8vz-\d+-/...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/129058#dependencies

6 fixed

• system_tests_audio

  • TC_20_AudioVM_Pulse_whonix-workstation-17: test_223_audio_play_hvm (failure)
    AssertionError: too short audio, expected 10s, got 7.33528344671201...

  • TC_20_AudioVM_PipeWire_whonix-workstation-17: test_226_audio_playback_pipewire (failure)
    AssertionError: too short audio, expected 10s, got 9.19027210884353...

  • TC_20_AudioVM_PipeWire_whonix-workstation-17: test_251_audio_playback_audiovm_pipewire_late_start (failure)
    AssertionError: too short audio, expected 10s, got 9.22900226757369...

• system_tests_qrexec

  • TC_00_Qrexec_whonix-workstation-17: test_070_qrexec_vm_simultaneous_write (failure)
    exited with non-zero code 125; stderr: b"dd: error writing 'standa...

• system_tests_whonix

  • whonixcheck: fail (unknown)
    Whonixcheck for sys-whonix failed...

  • whonixcheck: unnamed test (unknown)

Unstable tests

Details

Performance Tests

Performance degradation:

No issues

Remaining performance tests:

No remaining performance tests