add qubes_pure_sanitize_string_safe_for_display#136
Open
piotrbartman wants to merge 1 commit intoQubesOS:mainfrom
Open
add qubes_pure_sanitize_string_safe_for_display#136piotrbartman wants to merge 1 commit intoQubesOS:mainfrom
piotrbartman wants to merge 1 commit intoQubesOS:mainfrom
Conversation
Added function replaces unacceptable characters with `_`. I considered replacing `_` with the REPLACEMENT CHARACTER (U+FFFD) but the advantage of `_` is readability and the single-byte size. The internal `validate_utf8_char` function has been renamed to `validate_utf8_char_safe_for_display`, and the internal logic has been moved to `validate_utf8_char_and_return_len`, which returns the minus length of unsafe characters. This allows more efficient replacement of multi-byte UTF chars.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
==========================================
+ Coverage 60.60% 61.96% +1.35%
==========================================
Files 6 6
Lines 952 986 +34
Branches 104 104
==========================================
+ Hits 577 611 +34
Misses 285 285
Partials 90 90 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added function replaces unacceptable characters with
_. I considered replacing_with the REPLACEMENT CHARACTER (U+FFFD) but the advantage of_is readability and the single-byte size.The internal
validate_utf8_charfunction has been renamed tovalidate_utf8_char_safe_for_display, and the internal logic has been moved tovalidate_utf8_char_and_return_len, which returns the minus length of unsafe characters. This allows more efficient replacement of multi-byte UTF chars.