Retire old `qubes-vm-create` dialog #393

alimirjamali · 2024-11-09T18:47:25Z

alimirjamali · 2024-11-10T17:46:37Z

Development notes: Adding python3-xdg to requirements to let the CI/CD tests run. Dependency was introduced during #375

marmarek · 2024-11-14T16:10:01Z

As noted in the other issue, IMO better to simply remove the old create qube dialog (and replace its use with the new one).

marmarek · 2024-11-14T16:10:56Z

I'll pick just the dependency fix from here

alimirjamali · 2024-11-14T16:23:46Z

As noted in the other issue, IMO better to simply remove the old create qube dialog (and replace its use with the new one).

OK. But I think it is better to do it for 4.3 branch and not 4.2. I will make a separate PR for the above task, properly ditching the old one. So it could be easily merged to 4.3 branch.

marmarek · 2024-11-14T16:27:11Z

Well, "main" branch is "4.3 branch" :)

qubesmanager/qube_manager.py

qubesos-bot · 2024-11-26T04:19:03Z

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024112705-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025021804-4.3&flavor=update

system_tests_basic_vm_qrexec_gui_zfs
- switch_pool: Failed (test died)
  # Test died: command 'dnf install -y ./zfs-release.rpm' failed at /...
system_tests_audio
- TC_20_AudioVM_PipeWire_debian-12-xfce: test_260_audio_mic_enabled_switch_audiovm (failure)
  AssertionError: too short audio, expected 10s, got 0.00013605442176...
system_tests_kde_gui_interactive
- gui_keyboard_layout: wait_serial (wait serial expected)
  # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...
- gui_keyboard_layout: Failed (test died)
  # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...

Failed tests

5 failures

system_tests_basic_vm_qrexec_gui_zfs
- switch_pool: Failed (test died)
  # Test died: command 'dnf install -y ./zfs-release.rpm' failed at /...
system_tests_audio
- TC_20_AudioVM_PipeWire_debian-12-xfce: test_260_audio_mic_enabled_switch_audiovm (failure)
  AssertionError: too short audio, expected 10s, got 0.00013605442176...
- [unstable] TC_20_AudioVM_PipeWire_fedora-40-xfce: test_260_audio_mic_enabled_switch_audiovm (failure)
  AssertionError: too short audio, expected 10s, got 0.00013605442176...
system_tests_kde_gui_interactive
- gui_keyboard_layout: wait_serial (wait serial expected)
  # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...
- gui_keyboard_layout: Failed (test died)
  # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/129058#dependencies

15 fixed

system_tests_whonix@hw7
- whonixcheck: fail (unknown)
  Whonixcheck for sys-whonix failed...
- whonixcheck: unnamed test (unknown)
system_tests_suspend@hw1
- suspend: unnamed test (unknown)
- suspend: Failed (test died)
  # Test died: no candidate needle with tag(s) 'SUSPEND-FAILED' match...
system_tests_whonix
- whonixcheck: fail (unknown)
  Whonixcheck for sys-whonix failed...
- whonixcheck: unnamed test (unknown)
system_tests_suspend
- suspend: unnamed test (unknown)
- suspend: Failed (test died)
  # Test died: no candidate needle with tag(s) 'SUSPEND-FAILED' match...
system_tests_qrexec
- TC_00_Qrexec_whonix-workstation-17: test_070_qrexec_vm_simultaneous_write (failure)
  exited with non-zero code 125; stderr: b"dd: error writing 'standa...
system_tests_audio
- TC_20_AudioVM_Pulse_whonix-workstation-17: test_223_audio_play_hvm (failure)
  AssertionError: too short audio, expected 10s, got 7.33528344671201...
- TC_20_AudioVM_PipeWire_whonix-workstation-17: test_226_audio_playback_pipewire (failure)
  AssertionError: too short audio, expected 10s, got 9.19027210884353...
- TC_20_AudioVM_PipeWire_whonix-workstation-17: test_251_audio_playback_audiovm_pipewire_late_start (failure)
  AssertionError: too short audio, expected 10s, got 9.22900226757369...
system_tests_basic_vm_qrexec_gui_btrfs
- TC_03_QvmRevertTemplateChanges: test_000_revert_linux (error)
  subprocess.CalledProcessError: Command '['sha1sum', '/var/lib/qubes...
system_tests_kde_gui_interactive
- clipboard_and_web: unnamed test (unknown)
- clipboard_and_web: Failed (test died)
  # Test died: no candidate needle with tag(s) 'clipboard-paste-notif...

Unstable tests

Details

system_tests_audio@hw1
TC_20_AudioVM_Pulse_fedora-40-xfce/test_223_audio_play_hvm (1/5 times with errors)
- job 115623 libvirt.libvirtError: internal error: libxenlight failed to create ...
TC_20_AudioVM_Pulse_debian-12-xfce/test_224_audio_rec_muted_hvm (1/5 times with errors)
- job 115623 libvirt.libvirtError: internal error: libxenlight failed to create ...
TC_20_AudioVM_Pulse_whonix-workstation-17/test_224_audio_rec_muted_hvm (1/5 times with errors)
- job 115623 libvirt.libvirtError: internal error: libxenlight failed to create ...
TC_20_AudioVM_Pulse_debian-12-xfce/test_225_audio_rec_unmuted_hvm (1/5 times with errors)
- job 115623 libvirt.libvirtError: internal error: libxenlight failed to create ...
TC_20_AudioVM_Pulse_whonix-workstation-17/test_225_audio_rec_unmuted_hvm (1/5 times with errors)
- job 115623 libvirt.libvirtError: internal error: libxenlight failed to create ...
TC_20_AudioVM_PipeWire_whonix-workstation-17/test_251_audio_playback_audiovm_pipewire_late_start (1/5 times with errors)
- job 115623 AssertionError: too short audio, expected 10s, got 9.34507936507936...
TC_20_AudioVM_Pulse_debian-12-xfce/test_252_audio_playback_audiovm_switch_hvm (1/5 times with errors)
- job 115623 libvirt.libvirtError: internal error: libxenlight failed to create ...
TC_20_AudioVM_Pulse_fedora-40-xfce/test_252_audio_playback_audiovm_switch_hvm (1/5 times with errors)
- job 115623 libvirt.libvirtError: internal error: libxenlight failed to create ...
TC_20_AudioVM_Pulse_whonix-workstation-17/test_252_audio_playback_audiovm_switch_hvm (1/5 times with errors)
- job 115623 libvirt.libvirtError: internal error: libxenlight failed to create ...
TC_20_AudioVM_PipeWire_fedora-40-xfce/test_260_audio_mic_enabled_switch_audiovm (2/5 times with errors)
- job 116847 AssertionError: too short audio, expected 10s, got 0.00013605442176...
- job 117586 AssertionError: too short audio, expected 10s, got 0.00013605442176...
TC_20_AudioVM_PipeWire_whonix-workstation-17/test_260_audio_mic_enabled_switch_audiovm (1/5 times with errors)
- job 115623 AssertionError: too short audio, expected 10s, got 9.05353741496598...
system_tests_pvgrub_salt_storage
TC_41_HVMGrub_debian-12-xfce/test_000_standalone_vm (1/5 times with errors)
- job 115648 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
TC_41_HVMGrub_fedora-40-xfce/test_000_standalone_vm (1/5 times with errors)
- job 115648 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
TC_41_HVMGrub_debian-12-xfce/test_010_template_based_vm (1/5 times with errors)
- job 115648 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
TC_41_HVMGrub_fedora-40-xfce/test_010_template_based_vm (1/5 times with errors)
- job 115648 qubes.exc.QubesVMError: Cannot connect to qrexec agent for 120 seco...
system_tests_usbproxy
TC_20_USBProxy_core3_fedora-40-xfce/test_070_attach_not_installed_front (1/5 times with errors)
- job 117582 NameError: name 'santizied_stderr' is not defined
system_tests_network_updates
VmUpdates_debian-12-xfce/test_020_updates_available_notification (1/5 times with errors)
- job 117610 subprocess.CalledProcessError: Command '/usr/lib/qubes/upgrades-sta...
system_tests_basic_vm_qrexec_gui_zfs
TC_00_Basic/test_120_start_standalone_with_cdrom_dom0 (1/5 times with errors)
- job 109480 AssertionError: 1 != 0 : b'Timeout waiting for dom0:loop6 device to...
system_tests_audio
TC_20_AudioVM_Pulse_fedora-40-xfce/test_223_audio_play_hvm (1/5 times with errors)
- job 115623 libvirt.libvirtError: internal error: libxenlight failed to create ...
TC_20_AudioVM_Pulse_debian-12-xfce/test_224_audio_rec_muted_hvm (1/5 times with errors)
- job 115623 libvirt.libvirtError: internal error: libxenlight failed to create ...
TC_20_AudioVM_Pulse_whonix-workstation-17/test_224_audio_rec_muted_hvm (1/5 times with errors)
- job 115623 libvirt.libvirtError: internal error: libxenlight failed to create ...
TC_20_AudioVM_Pulse_debian-12-xfce/test_225_audio_rec_unmuted_hvm (1/5 times with errors)
- job 115623 libvirt.libvirtError: internal error: libxenlight failed to create ...
TC_20_AudioVM_Pulse_whonix-workstation-17/test_225_audio_rec_unmuted_hvm (1/5 times with errors)
- job 115623 libvirt.libvirtError: internal error: libxenlight failed to create ...
TC_20_AudioVM_PipeWire_whonix-workstation-17/test_251_audio_playback_audiovm_pipewire_late_start (1/5 times with errors)
- job 115623 AssertionError: too short audio, expected 10s, got 9.34507936507936...
TC_20_AudioVM_Pulse_debian-12-xfce/test_252_audio_playback_audiovm_switch_hvm (1/5 times with errors)
- job 115623 libvirt.libvirtError: internal error: libxenlight failed to create ...
TC_20_AudioVM_Pulse_fedora-40-xfce/test_252_audio_playback_audiovm_switch_hvm (1/5 times with errors)
- job 115623 libvirt.libvirtError: internal error: libxenlight failed to create ...
TC_20_AudioVM_Pulse_whonix-workstation-17/test_252_audio_playback_audiovm_switch_hvm (1/5 times with errors)
- job 115623 libvirt.libvirtError: internal error: libxenlight failed to create ...
TC_20_AudioVM_PipeWire_fedora-40-xfce/test_260_audio_mic_enabled_switch_audiovm (2/5 times with errors)
- job 116847 AssertionError: too short audio, expected 10s, got 0.00013605442176...
- job 117586 AssertionError: too short audio, expected 10s, got 0.00013605442176...
TC_20_AudioVM_PipeWire_whonix-workstation-17/test_260_audio_mic_enabled_switch_audiovm (1/5 times with errors)
- job 115623 AssertionError: too short audio, expected 10s, got 9.05353741496598...

Performance Tests

Performance degradation:

No issues

Remaining performance tests:

No remaining performance tests

marmarek · 2025-01-03T17:39:41Z

Now that #400 is merged, this needs rebase...

Retire the the old PyQt based `qubes-vm-create` dialog and replace it with GTK based `qubes-new-qube` for Qube Manager. resolves: QubesOS/qubes-issues#6561

codecov · 2025-02-07T19:06:16Z

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 68.29%. Comparing base (dc58ea1) to head (04de057).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
qubesmanager/qube_manager.py	16.66%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
+ Coverage   65.82%   68.29%   +2.46%     
==========================================
  Files          18       17       -1     
  Lines        3901     3715     -186     
==========================================
- Hits         2568     2537      -31     
+ Misses       1333     1178     -155

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

alimirjamali force-pushed the issue-6561-qubes-vm-create branch 2 times, most recently from be68559 to 14cc82d Compare November 10, 2024 18:13

alimirjamali marked this pull request as draft November 15, 2024 20:16

alimirjamali force-pushed the issue-6561-qubes-vm-create branch from 14cc82d to c79cbf5 Compare November 16, 2024 19:39

alimirjamali changed the title ~~Add Create Qubes VM to the xfce4-panel menu~~ Retire old qubes-vm-create dialog Nov 16, 2024

alimirjamali marked this pull request as ready for review November 16, 2024 19:42

marmarek requested a review from marmarta November 22, 2024 01:47

marmarta suggested changes Nov 25, 2024

View reviewed changes

qubesmanager/qube_manager.py Outdated Show resolved Hide resolved

alimirjamali force-pushed the issue-6561-qubes-vm-create branch 2 times, most recently from e4f6046 to 210f867 Compare November 25, 2024 14:12

alimirjamali requested a review from marmarta November 25, 2024 14:47

marmarek added the openqa-pending label Nov 25, 2024

qubesos-bot mentioned this pull request Nov 26, 2024

Fix up GPT partition tables automatically QubesOS/qubes-linux-utils#119

Merged

10 tasks

This was referenced Dec 3, 2024

Try to retrieve exit code of a failed service call QubesOS/qubes-core-qrexec#183

Merged

audio: fix reacting on mic enable/disable requests QubesOS/qubes-gui-daemon#161

Merged

marmarek removed the openqa-pending label Jan 3, 2025

Retire old qubes-vm-create dialog

04de057

Retire the the old PyQt based `qubes-vm-create` dialog and replace it with GTK based `qubes-new-qube` for Qube Manager. resolves: QubesOS/qubes-issues#6561

alimirjamali force-pushed the issue-6561-qubes-vm-create branch from 210f867 to 04de057 Compare February 7, 2025 18:47

marmarek added the openqa-pending label Feb 7, 2025

marmarek approved these changes Feb 9, 2025

View reviewed changes

marmarek merged commit 04de057 into QubesOS:main Feb 9, 2025
3 of 5 checks passed

marmarta mentioned this pull request Jul 3, 2025

App menu contains both "Create New Qube" and "Create Qubes VM" tools QubesOS/qubes-issues#8673

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Retire old `qubes-vm-create` dialog #393

Retire old `qubes-vm-create` dialog #393

Uh oh!

alimirjamali commented Nov 9, 2024

Uh oh!

alimirjamali commented Nov 10, 2024

Uh oh!

marmarek commented Nov 14, 2024

Uh oh!

marmarek commented Nov 14, 2024 •

edited

Loading

Uh oh!

alimirjamali commented Nov 14, 2024 •

edited

Loading

Uh oh!

marmarek commented Nov 14, 2024

Uh oh!

Uh oh!

qubesos-bot commented Nov 26, 2024 •

edited

Loading

Uh oh!

marmarek commented Jan 3, 2025

Uh oh!

codecov bot commented Feb 7, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Retire old qubes-vm-create dialog #393

Retire old qubes-vm-create dialog #393

Uh oh!

Conversation

alimirjamali commented Nov 9, 2024

Uh oh!

alimirjamali commented Nov 10, 2024

Uh oh!

marmarek commented Nov 14, 2024

Uh oh!

marmarek commented Nov 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alimirjamali commented Nov 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marmarek commented Nov 14, 2024

Uh oh!

Uh oh!

qubesos-bot commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

OpenQA test summary

New failures, excluding unstable

Failed tests

Fixed failures

Unstable tests

Performance Tests

Performance degradation:

Remaining performance tests:

Uh oh!

marmarek commented Jan 3, 2025

Uh oh!

codecov bot commented Feb 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Retire old `qubes-vm-create` dialog #393

Retire old `qubes-vm-create` dialog #393

marmarek commented Nov 14, 2024 •

edited

Loading

alimirjamali commented Nov 14, 2024 •

edited

Loading

qubesos-bot commented Nov 26, 2024 •

edited

Loading

codecov bot commented Feb 7, 2025 •

edited

Loading