Skip to content

Make Devices tab prettier & safer #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marmarek merged 1 commit into from
May 25, 2025
Merged

Make Devices tab prettier & safer #421

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions qubesmanager/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1381,9 +1381,14 @@ def __init_devices_tab__(self):
self.devices_layout.addWidget(self.dev_list)

try:
dom0_devs = \
list(self.vm.app.domains['dom0'].
devices['pci'].get_exposed_devices())
dom0_devs = list(
dev
for dev in self.vm.app.domains["dom0"]
.devices["pci"]
.get_exposed_devices()
if dev.interfaces[0].category
!= device_protocol.DeviceCategory.PCI_Bridge
)
attached = list(
self.vm.devices['pci'].get_assigned_devices(required_only=True))
except qubesadmin.exc.QubesException:
Expand All @@ -1395,7 +1400,11 @@ def __init_devices_tab__(self):
class DevListWidgetItem(QtWidgets.QListWidgetItem):
def __init__(self, dev, unknown=False, parent=None):
super().__init__(parent)
name = dev.port_id.replace('_', ":") + ' ' + dev.description
name = (
dev.port_id.replace("_", ":").replace("-", " -> ")
+ " "
+ dev.description
)
if unknown:
name += ' (unknown)'
self.setText(name)
Expand Down