Skip to content

Fix tests for changes in mock API #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marmarek merged 1 commit into from
May 28, 2025
Merged

Fix tests for changes in mock API #423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions qubesmanager/tests/test_vm_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,11 @@ def settings_fixture(request, qapp, test_qubes_app) -> Tuple[
name="anon-whonix", qapp=test_qubes_app, tags=['anon-vm'])

test_qubes_app._devices.append(
MockDevice(test_qubes_app, 'pci', 'USB Controller', '00:03.2',
'dom0', attached='test-pci-dev'))
MockDevice(
test_qubes_app, dev_class='pci',
device_id='0x8008:0x1234::p040000', backend_vm='dom0',
port='00_04.3', product='Important Device', vendor='Test',
assigned=[('test-pci-dev', 'required', None)]))

# add a TemplateVM with some boot modes
test_qubes_app._qubes['fedora-36-bootmodes'] = MockQube(
Expand Down Expand Up @@ -1710,7 +1713,7 @@ def test_600_devices(settings_fixture):
item = settings_window.dev_list.available_list.item(i)
available_items.append(item.text())

assert len(available_items) == 4
assert len(available_items) == 3


@check_errors
Expand All @@ -1730,8 +1733,8 @@ def test_601_device_add(settings_fixture):
settings_window.dev_list.add_selected_button.click()

expected_call = (
vm.name, 'admin.vm.device.pci.Assign', 'dom0+00_03.2:*',
b"device_id='*' port_id='00_03.2' devclass='pci' "
vm.name, 'admin.vm.device.pci.Assign', 'dom0+00_03.0:*',
b"device_id='*' port_id='00_03.0' devclass='pci' "
b"backend_domain='dom0' mode='required' "
b"frontend_domain='test-vm-set'")
assert expected_call not in settings_window.qubesapp.actual_calls
Expand All @@ -1753,7 +1756,7 @@ def test_602_device_remove(settings_fixture):
item = settings_window.dev_list.available_list.item(i)
available_items.append(item.text())

assert len(available_items) == 4
assert len(available_items) == 2

selected_items = []
for i in range(settings_window.dev_list.selected_list.count()):
Expand All @@ -1765,8 +1768,8 @@ def test_602_device_remove(settings_fixture):

settings_window.dev_list.remove_selected_button.click()

expected_call = (vm.name, 'admin.vm.device.pci.Unassign', 'dom0+00:03.2',
None)
expected_call = (vm.name, 'admin.vm.device.pci.Unassign',
'dom0+00_04.3:0x8008:0x1234::p040000', None)
assert expected_call not in settings_window.qubesapp.actual_calls
settings_window.qubesapp.expected_calls[expected_call] = b'0\x00'

Expand Down