Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional backoff #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

roberttod
Copy link
Contributor

No description provided.

rtod added 2 commits December 22, 2020 15:51
- Sometimes JS runs when wifi chip is off (during sleep) causing massive backoffs for no reason
- Required for tests to run
@roberttod
Copy link
Contributor Author

@oliverwoodings would you mind looking at this when you get a chance, else I might have to fork it. On your side you'd probably see an increase in accuracy with this on too.

Copy link

@oliverwoodings oliverwoodings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the very late review! Code change LGTM, just need to update the docs

@@ -19,7 +19,7 @@ Queue That is built primarily to queue XHR requests for reporting.

- When more than one tab is open, only one active queue will process tasks.
- If `options.process` calls back with an error, the tasks will be passed to `options.process`
again after a second. This backoff time doubles for each sequential error. The backoff timer is
again after a second. This backoff time doubles for each sequential error, up to `options.maxBackoff` (5 minutes by default). The backoff timer is

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add this config option into the API documentation section below?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants