Skip to content

✨ Optimize ChatItem and StreamItem components and reduce rerender #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuentinVdr merged 2 commits into from
Sep 17, 2025
Merged

✨ Optimize ChatItem and StreamItem components and reduce rerender #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3d8e8a
✨ Optimize ChatItem and StreamItem components: memoize components for…
QuentinVdr Sep 17, 2025
964b3ad
✨ Add custom props comparison
QuentinVdr Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions src/components/gridItems/ChatItem/ChatItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useMemo } from 'react';
import { memo } from 'react';
import GridItem from '../GridItem/GridItem';
import ChatItemHeader from './ChatItemHeader/ChatItemHeader';

Expand All @@ -7,20 +7,21 @@ interface ChatItemProps {
isDarkThemePreferred?: boolean;
}

const ChatItem = ({ streamName, isDarkThemePreferred = false }: ChatItemProps) => {
const title = `Chat: ${streamName}`;
const ChatItem = memo(
({ streamName, isDarkThemePreferred = false }: ChatItemProps) => {
const title = `Chat: ${streamName}`;
const iframeSrc = `https://www.twitch.tv/embed/${streamName}/chat?parent=${window.location.hostname}${isDarkThemePreferred ? '&darkpopout' : ''}`;

const iframeSrc = useMemo(() => {
const darkParam = isDarkThemePreferred ? '&darkpopout' : '';
return `https://www.twitch.tv/embed/${streamName}/chat?parent=${window.location.hostname}${darkParam}`;
}, [streamName, isDarkThemePreferred]);

return (
<GridItem title={title} iframeSrc={iframeSrc} streamName={streamName}>
<ChatItemHeader streamName={streamName} />
</GridItem>
);
};
return (
<GridItem title={title} iframeSrc={iframeSrc} streamName={streamName}>
<ChatItemHeader streamName={streamName} />
</GridItem>
);
},
(prev, next) =>
prev.isDarkThemePreferred === next.isDarkThemePreferred &&
prev.streamName.toLowerCase() === next.streamName.toLowerCase()
);

ChatItem.displayName = 'ChatItem';

Expand Down
1 change: 1 addition & 0 deletions src/components/gridItems/GridItem/GridItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ const GridItem = memo(
</GridItemHeader>
<iframe
ref={iframeRef}
key={iframeSrc}
title={title}
src={iframeSrc}
height="100%"
Expand Down
31 changes: 17 additions & 14 deletions src/components/gridItems/StreamItem/StreamItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,31 @@
import { useCallback, useRef } from 'react';
import { memo, useCallback, useRef } from 'react';
import GridItem, { type GridItemRef } from '../GridItem/GridItem';
import StreamItemHeader from './StreamItemHeader/StreamItemHeader';

interface StreamItemProps {
streamName: string;
}

const StreamItem = ({ streamName }: StreamItemProps) => {
const gridItemRef = useRef<GridItemRef>(null);
const StreamItem = memo(
({ streamName }: StreamItemProps) => {
const gridItemRef = useRef<GridItemRef>(null);

const title = `Stream: ${streamName}`;
const title = `Stream: ${streamName}`;

const iframeSrc = `https://player.twitch.tv/?channel=${streamName}&parent=${window.location.hostname}`;
const iframeSrc = `https://player.twitch.tv/?channel=${streamName}&parent=${window.location.hostname}`;

const handleRefresh = useCallback(() => {
gridItemRef.current?.refreshIframe();
}, []);
const handleRefresh = useCallback(() => {
gridItemRef.current?.refreshIframe();
}, []);

return (
<GridItem ref={gridItemRef} title={title} iframeSrc={iframeSrc} allowFullScreen streamName={streamName}>
<StreamItemHeader streamName={streamName} handleRefresh={handleRefresh} />
</GridItem>
);
};
return (
<GridItem ref={gridItemRef} title={title} iframeSrc={iframeSrc} allowFullScreen streamName={streamName}>
<StreamItemHeader streamName={streamName} handleRefresh={handleRefresh} />
</GridItem>
);
},
(prev, next) => prev.streamName.toLowerCase() === next.streamName.toLowerCase()
);

StreamItem.displayName = 'StreamItem';

Expand Down