feat: make pause idempotent and emit pause events#1675
Merged
Baskarayelu merged 1 commit intoJun 27, 2026
Conversation
|
@AugistineCreates Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
make pause idempotent and emit pause events — good stuff, merging 👍 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr closes #1544
📝 Description
This PR resolves the issue where consecutive calls to
pause()would duplicate emitted events. We ensure thatpause()is fully idempotent by only emitting thePausedevent on an actual transition to the paused state (and similarly forunpause()).🎯 Type of Change
🔧 Changes Made
Files Modified
quicklendx-contracts/src/pause.rs— Added idempotency validation usingSelf::is_paused(env)before updating state or emitting events.quicklendx-contracts/src/test_pause.rs— Addedtest_pause_idempotent_no_duplicate_eventsto count and verify that duplicate events are not produced whenpause()is called twice.🧪 Testing