Skip to content

Fix issues 1523 1519#1680

Merged
Baskarayelu merged 2 commits into
QuickLendX:mainfrom
dorismaduegbunam:fix-issues-1523-1519
Jun 27, 2026
Merged

Fix issues 1523 1519#1680
Baskarayelu merged 2 commits into
QuickLendX:mainfrom
dorismaduegbunam:fix-issues-1523-1519

Conversation

@dorismaduegbunam

Copy link
Copy Markdown
Contributor

This PR addresses two separate issues by expanding our test coverage and internal documentation on KYC gating limits.

Changes:

  1. compute_expected_return Proptests:
    • Introduced compute_expected_return to quicklendx-contracts/src/profits.rs.
    • Added exhaustive property testing in src/test_compute_yield_props.rs ensuring the expected return remains non-negative, stays bounded by the system's MAX_RATE_BPS, and appropriately factors in the principal amount.

Closes #1523

  1. KYC Gating Documentation:
    • Authored docs/KYC.md targeting operators, which breaks down the gating criteria between Business KYC (invoice listing, funding) and Investor KYC (bidding, withdrawals) using concrete JSON payload examples.
    • Linked the new guide in the top-level README.md for proper discoverability.

Closes #1519

Verification:

  • Executed cargo test -p quicklendx-contracts --features fuzz-tests to successfully validate new properties locally.
  • Maintained no_std compliance and verified WASM compilation via cargo build --target wasm32-unknown-unknown --release.
  • Ensured formatting passes standard checks.

@drips-wave

drips-wave Bot commented Jun 26, 2026

Copy link
Copy Markdown

@dorismaduegbunam Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Baskarayelu

Copy link
Copy Markdown
Contributor

Fix issues 1523 1519 — exactly what we wanted. merging 👍

@Baskarayelu Baskarayelu merged commit 831e58b into QuickLendX:main Jun 27, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add proptest for compute_expected_return Add docs/KYC.md

3 participants