Add proposal app hash + step hashes#47
Conversation
ahdzib-maya
force-pushed
the
feat/add-hashes
branch
from
f1b6584 to
de60bad
Compare
|
Hi, thanks for your contribution, sorry for taking that much time to respond! I was thinking about the following: there are basically 3 options a validator can vote: nil (not voting), zeroes (disagreeing with the proposer) and non-zeroes (agreeing with the proposer), and they are already represented by emojis, so I wonder whether it makes sense to also display actual votes? In my opinion, this makes the interface extra complex, which might be not what people want. Also would for sure be helpful to add it to AllRoundsTable, to see votes per each round. |
| // Fetch app_hash from the proposed block | ||
| appHash, err := a.Aggregator.GetAppHash() | ||
| if err != nil { | ||
| a.Logger.Debug().Err(err).Msg("Could not get app hash from proposed block") |
There was a problem hiding this comment.
Can we also add SetState with error to display that there was an error fetching data, the same way it's done for SetTendermintResponse?
|
|
||
| return fmt.Sprintf( | ||
| " %s %s %s %s%% %s ", | ||
| " %s%s %s%s %s %s%% %s ", |
There was a problem hiding this comment.
let's maybe add another space between the emoji and the vote itself? otherwise it looks a bit ugly
2 participants
Kind of addresses #42
Did this change to debug a consensus failure on Maya Protocol mainnet and it worked well, so I thought of opening the PR.