feat: enhance locale handling with AsyncLocalStorage support for server-side requests #7826

JerryWu1234 · 2025-08-15T08:26:55Z

feat: enhance locale handling with AsyncLocalStorage support for server-side requests

#7806

What is it?

Feature / enhancement
Bug
Docs / tests / types / typos
Infra

Description

Checklist

My code follows the developer guidelines of this project
I performed a self-review of my own code
I added a changeset with pnpm change
I made corresponding changes to the Qwik docs
I added new tests to cover the fix / functionality

…er-side requests

changeset-bot · 2025-08-15T08:26:59Z

🦋 Changeset detected

Latest commit: ef75798

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

pkg-pr-new · 2025-08-15T08:39:37Z

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@7826

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@7826

npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@7826

npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@7826

commit: ef75798

github-actions · 2025-08-15T08:39:57Z

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name	Status	Preview	Last Commit
qwik-docs	✅ Ready (View Log)	Visit Preview	`ef75798`

…torage support

JerryWu1234 · 2025-08-15T09:37:33Z

@wmertens does it need a test?.

wmertens

Good start but I think Core should not be influenced by Router.

packages/qwik-router/src/middleware/request-handler/user-response.ts

packages/qwik/src/core/use/use-locale.ts

…r-side context

packages/qwik-router/src/middleware/request-handler/user-response.ts

packages/qwik-router/src/runtime/src/head.ts

packages/qwik/src/core/use/use-locale.ts

…head.ts

packages/qwik-router/src/middleware/request-handler/user-response.ts

packages/qwik-router/src/runtime/src/head.ts

packages/qwik/src/core/use/use-locale.ts

…al in use-locale.ts

JerryWu1234 · 2025-08-19T09:03:43Z

@wmertens done .please check it again , thanks

packages/qwik-router/src/runtime/src/head.ts

packages/qwik/src/core/use/use-locale.ts

…improve request handling

wmertens

Almost there :)

packages/qwik-router/src/runtime/src/head.ts

packages/qwik/src/core/use/use-locale.ts

…improve code clarity

…al in use-locale.ts

JerryWu1234 · 2025-08-26T06:24:07Z

@wmertens still need a global variable qcAsyncRequestStore.
because in server-functions file can't read asyncRequestStore

packages/qwik/src/core/use/use-locale.ts

packages/qwik-router/src/middleware/request-handler/user-response.ts

wmertens · 2025-09-08T18:50:08Z

packages/qwik-router/src/runtime/src/server-functions.ts

@@ -420,7 +421,7 @@ export const serverQrl = <T extends ServerFunction>(

      if (isServer) {
        // Running during SSR, we can call the function directly
-        let requestEvent = globalThis.qcAsyncRequestStore?.getStore() as RequestEvent | undefined;
+        let requestEvent = asyncRequestStore?.getStore() as RequestEvent | undefined;


you say it has to be a global for server-functions.ts, but it's not using the global?

…nd locale management

wmertens

The fact that the current code will not update the async store tells me that we need a test for this. We should have an e2e test that requests the same route twice but with different locales, and with a promise in the middle of the page that gets resolved once both requests are being rendered.

packages/qwik/src/core/use/use-locale.ts

packages/qwik-router/src/middleware/request-handler/async-request-store.ts

…stStore initialization

… enhance code organization

feat: enhance locale handling with AsyncLocalStorage support for serv…

4664b34

…er-side requests

JerryWu1234 changed the title ~~feat: enhance locale handling with AsyncLocalStorage support for serv…~~ feat: enhance locale handling with AsyncLocalStorage support for server-side requests Aug 15, 2025

JerryWu1234 added 2 commits August 15, 2025 16:43

add changeset

90890c9

fix: improve locale handling in resolveHead function with AsyncLocalS…

25d1648

…torage support

JerryWu1234 self-assigned this Aug 15, 2025

JerryWu1234 marked this pull request as ready for review August 15, 2025 09:37

JerryWu1234 requested a review from a team as a code owner August 15, 2025 09:37

wmertens requested changes Aug 15, 2025

View reviewed changes

packages/qwik-router/src/middleware/request-handler/user-response.ts Outdated Show resolved Hide resolved

packages/qwik/src/core/use/use-locale.ts Show resolved Hide resolved

refactor: streamline locale handling with AsyncLocalStorage for serve…

0abc9d8

…r-side context

wmertens requested changes Aug 16, 2025

View reviewed changes

refactor: remove unnecessary comment and simplify store retrieval in …

27dd795

…head.ts

wmertens requested changes Aug 18, 2025

View reviewed changes

refactor: simplify AsyncLocalStorage usage and improve locale retriev…

1c341e4

…al in use-locale.ts

JerryWu1234 added this to Qwik Development Aug 19, 2025

github-project-automation bot moved this to Backlog in Qwik Development Aug 19, 2025

JerryWu1234 moved this from Backlog to Waiting For Review in Qwik Development Aug 19, 2025

wmertens requested changes Aug 21, 2025

View reviewed changes

JerryWu1234 added 2 commits August 25, 2025 13:42

refactor: unify AsyncLocalStorage usage across router middleware and …

92d67da

…improve request handling

Merge branch 'build/v2' into buildv2async

ce8d18b

wmertens requested changes Aug 25, 2025

View reviewed changes

JerryWu1234 added 2 commits August 26, 2025 10:24

refactor: streamline AsyncLocalStorage usage in locale functions and …

559b9f3

…improve code clarity

refactor: simplify AsyncLocalStorage usage and improve locale retriev…

0e148b7

…al in use-locale.ts

refactor: remove debug log for AsyncLocalStorage in user-response.ts

c1c07c6

wmertens requested changes Sep 8, 2025

View reviewed changes

refactor: enhance AsyncLocalStorage integration in request handling a…

888e4df

…nd locale management

wmertens requested changes Sep 10, 2025

View reviewed changes

JerryWu1234 added 2 commits September 10, 2025 18:43

refactor: remove server-side check in setLocale and update asyncReque…

1609ffd

…stStore initialization

refactor: optimize AsyncLocalStorage handling in locale functions and…

ef75798

… enhance code organization

feat: enhance locale handling with AsyncLocalStorage support for server-side requests #7826

Are you sure you want to change the base?

feat: enhance locale handling with AsyncLocalStorage support for server-side requests #7826

Uh oh!

Conversation

JerryWu1234 commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is it?

Description

Checklist

Uh oh!

changeset-bot bot commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

pkg-pr-new bot commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Uh oh!

JerryWu1234 commented Aug 15, 2025

Uh oh!

wmertens left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JerryWu1234 commented Aug 19, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wmertens left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JerryWu1234 commented Aug 26, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wmertens Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

wmertens left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JerryWu1234 commented Aug 15, 2025 •

edited

Loading

changeset-bot bot commented Aug 15, 2025 •

edited

Loading

pkg-pr-new bot commented Aug 15, 2025 •

edited

Loading

github-actions bot commented Aug 15, 2025 •

edited

Loading