Skip to content

Conversation

andreww2012
Copy link
Contributor

What is it?

  • Infra

Description

This PR replaces a very heavy jsx-ast-utils package with a much lighter alternative jsx-ast-utils-x, which has compatible API and zero dependencies.

A very popular ESLint plugin, eslint-plugin-sonarjs, has already performed this switch (see the original issue).

After this change the dependency graph and installation size of eslint-plugin-qwik package should reduce significantly.

Checklist

@andreww2012 andreww2012 requested a review from a team as a code owner September 11, 2025 09:58
Copy link

changeset-bot bot commented Sep 11, 2025

🦋 Changeset detected

Latest commit: cf45df3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
eslint-plugin-qwik Patch
@builder.io/qwik Patch
@builder.io/qwik-city Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Sep 11, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7938
npm i https://pkg.pr.new/@builder.io/qwik-city@7938
npm i https://pkg.pr.new/eslint-plugin-qwik@7938
npm i https://pkg.pr.new/create-qwik@7938

commit: cf45df3

Copy link
Contributor

github-actions bot commented Sep 11, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview cf45df3

Copy link
Contributor

@maiieul maiieul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. We will discuss this with the team first.

@maiieul maiieul moved this from Backlog to Waiting For Review in Qwik Development Sep 11, 2025
@maiieul maiieul assigned maiieul and unassigned maiieul Sep 11, 2025
@maiieul
Copy link
Contributor

maiieul commented Sep 12, 2025

@andreww2012 Apart faster npm i are there any other benefits to reducing the dep graph? Have you been able to measure faster performance when running the eslint plugin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Waiting For Review
Development

Successfully merging this pull request may close these issues.

2 participants