Skip to content

Feature inverse kinematics#23

Open
raubenravi wants to merge 8 commits into
releasefrom
feature_inverse_kinematics
Open

Feature inverse kinematics#23
raubenravi wants to merge 8 commits into
releasefrom
feature_inverse_kinematics

Conversation

@raubenravi
Copy link
Copy Markdown
Contributor

made structure for control the 3 axis robot arms and made a function to calculate the angle`s

@raubenravi raubenravi requested a review from JordyAlkema June 19, 2019 12:48
uint16_t get_angle_beta();
/**
* @brief
* get the vector cordinates of the end effector
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

uint16_t get_angle_theta();
/**
* @brief
* get the angle of beta after it calcualted by the
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

void set_position_end_effector(vector3i_c coordinate);
/**
* @brief
* get the angle of alhpa after it calcualted by the
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo


class calculate_inverse_kinematics_c {
private:
uint16_t arm_lengt1, arm_lengt2;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

private:
uint16_t arm_lengt1, arm_lengt2;
vector3i_c position_end_effector;
uint16_t angle_aplha, angle_beta, angle_phi, angle_theta;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo 'Aplha'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hasn't changed

/**
* Robot arm constructor
*/
calculate_inverse_kinematics_c(uint16_t arm_lengt1,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo 'lengt'

Comment thread code/headers/servo.hpp Outdated
#pragma once
#include <hwlib.hpp>
namespace r2d2::robot_arm {
class servo {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 'servo_c'

@raubenravi raubenravi requested a review from JordyAlkema July 1, 2019 08:47
private:
uint16_t arm_lengt1, arm_lengt2;
vector3i_c position_end_effector;
uint16_t angle_aplha, angle_beta, angle_phi, angle_theta;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hasn't changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants