refactor(config): remove RBLNConfig.load() past its 0.11.0 removal deadline - #644
Closed
rebel-jongho wants to merge 1 commit into
Closed
refactor(config): remove RBLNConfig.load() past its 0.11.0 removal deadline#644rebel-jongho wants to merge 1 commit into
rebel-jongho wants to merge 1 commit into
Conversation
rebel-jongho
force-pushed
the
refactor/remove-deprecated-config-load
branch
from
July 27, 2026 04:53
f2ef9b1 to
aea2034
Compare
…adline `RBLNAutoConfig.load()` and `RBLNModelConfig.load()` were thin wrappers that forwarded their arguments to `from_pretrained()`, marked for removal in 0.11.0 via `@deprecate_method`. Every 0.11.x build now raises on call: the current release is v0.11.0.post1, and since #614 the cutoff compares PEP 440 base versions, so alpha and dev builds are past it too. The deprecation policy in `utils/deprecation.py` calls for dropping them at this point. The now-unused `deprecate_method` import is dropped as well; the helper itself stays in `utils/deprecation.py` alongside `deprecate_kwarg` and is still covered by tests/test_base.py. Callers were already migrated: auto_factory.py in 235075e and test_load_config_object in 48217ce. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
rebel-jongho
marked this pull request as ready for review
July 27, 2026 04:54
rebel-seinpark
added a commit
that referenced
this pull request
Jul 27, 2026
Every 0.11.x build is past the 0.11.0 removal deadline, so the old `max_seq_lens` name already raises. Remove the decorator (and its now-unused import) from RBLNQwen3_5VisionModelConfig; `max_seq_len` is unaffected. This is the qwen3_5 slice of the follow-up deferred in #644. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
already merged in #645 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Type of Change
Changes Overview
Deletes the two deprecated
load()classmethods fromsrc/optimum/rbln/configuration_utils.py, decorator included.RBLNAutoConfig.load()andRBLNModelConfig.load()were thin wrappers forwarding their arguments verbatim tofrom_pretrained(), so callers only need to change the method name.deprecate_methodimport goes with them, since nothing in that module uses it anymore. The helper itself stays inutils/deprecation.pynext todeprecate_kwargand remains covered bytests/test_base.py::test_deprecate_method_raises_at_or_past_cutoff.No test changes are needed:
test_load_config_objectwas already switched tofrom_pretrained()in 48217ce.Motivation and Context
Both methods carried
@deprecate_method(version="0.11.0", new_method="from_pretrained"), and every 0.11.x build is now past that cutoff, so calling either one raisesValueErrorinstead of warning. Two things put us there:v0.11.0.post1became reachable fromdevwith the back-merge in other: revert misplaced post1 commit and back-merge main into dev #618, which pushed the hatch-vcs derived version to0.11.0.post2.devN.0.11.1aN.devM) are past it as well.The deprecation policy table at the top of
utils/deprecation.pyprescribes exactly this sequence: raise for one version, then drop the decorator. This PR performs that removal step.No callers remain.
auto_factory.pymoved tofrom_pretrained()in 235075e,test_load_config_objectin 48217ce, and a repository-wide search turns up no other references beyond the unrelatedload_from_dict.Verification
ruff checkandruff formatpass on the changed file. The change is a pure deletion of two unreachable wrappers plus the import that served them, so behaviour is unchanged for every code path that still works today.Out of Scope
The three
max_seq_lens→max_seq_lendeprecate_kwargentries on the Qwen2-VL / Qwen2.5-VL / Qwen3-VL vision configs share the same 0.11.0 cutoff and are equally past it, but no test or internal caller exercises them, so they are left for a follow-up.Related Issues
SR-365