Add Spawn Points by Lumminal · Pull Request #1490 · RE-SS3D/SS3D

Lumminal · 2026-02-10T22:45:02Z

Summary

Adds SpawnPoints which can be used by mappers for jobs and late-join players.
Map Editor has 3 new prefabs, SecuritySpawnPoint, AssistantSpawnPoint and LateJoinSpawnPoint.

The current maps have late join spawn points mapped in them (they act as fallback but work for now)

PR checklist

The game builds properly without errors.

No unrelated changes are present.

No "trash" files are committed.

Relevant code is documented.

Update the related GitBook document, or create a new one if needed.
Add art assets for spawn point prefabs
Add spawn points to available maps

Pictures/Videos

2026-02-12.16-38-20.mp4

Testing

Open server
Open client instances
Start round
Map some spawn points
Restart round
You should spawn at a spawn point according to your job or if you're late-joining. If you ready and there's no job spawn point, you should spawn at a random one.

Networking checklist

Works from host in host mode.

Works from server in server mode.

Works on server in client mode.

Works and is syncronized across different clients.

Is persistent.

Changes

Adds prefabs named SpawnPoints with their own script called Spawn Point which hold SpawnPointData (scriptable object) and get registered in SpawnPointManager (subsystem) when the round is warming up
Adds ScriptableObject that holds the data about the Spawn Point, like SpawnType (is this a spawn point for a job, or a late-join? can be expanded for observers once that is implemented), and the job related to this Spawn Point if there's any (for now assistant and security).
Added a new subsystem SpawnPointManager which handles spawning during EntitySubSystem's SpawnPlayer() method. It chooses between valid spawn points, and if it doesn't find one, it logs as an error and the client will spawn at EntitySubSystem's _spawnPoint position (which was how it worked before).
Adds a new visibility layer in Tags and Layers called "MapEditor" which gets activated for people once they have the map editor ui open. The SpawnPoints live on that layer, therefore only the map editors can see them. Tested with different clients.

Related issues/PRs

Closes #1435

Lumminal · 2026-02-13T16:13:21Z

I think its good for review.

Right now its still early to tell how it'll hold up with a full lobby, but it works for debugging cases. I tried to optimize it as much as I can. This is my first pr here so i hope i didn't write code that will burn your eyes

I tested this multiple ways:

2 clients and 1 host. Added spawn point for assistant, 5 late join spawners, 1 security spawn point. Press ready for everyone, sec spawned at sec spawn point, assistant at assistant spawn point and the other assistant at late-join spawn point as fallback.
Pressed embark by late-joining, spawned at late-join spawners without being on top of each other
Everyone shows up correctly on the screen, no issues with syncing but the sync code is kinda weird

iamteapot422

Some descriptions like /// <param name="playerThe player's ckey</param> and /// <param name="player"></param> The player we want to handle spawning for have wrong formats. Remove empty descriptions.

Rename Reserved to IsAvailable (I like Reserved, but the second name is more clear about the purpose). Make it a public getter and private setter. Rename Reserve() to Use()
Call Use() only after spawning the player in EntitySubSystem. Before this moment, SpawnPoint's or Manger's internal state shouldn't be changed.

Rename Job to RoundStart

iamteapot422 · 2026-02-20T19:52:38Z

Separate into two files

iamteapot422 · 2026-03-13T16:03:29Z

+        public void HandleRoundStateChanged(ref EventContext context, in RoundStateUpdated state)
+        {
+            // Clear all spawn points for new round
+            if (state.RoundState == RoundState.Preparing)


Invert if to reduce nesting

iamteapot422 · 2026-03-13T16:07:32Z

+
+            // Register the spawn point based on role
+            RoleData role = spawnPoint.SpawnPointData.RoleData;
+            if (role)


invert if to reduce nesting

iamteapot422 · 2026-03-13T16:08:48Z

+                    _spawnPoints[role] = points;
+                }
+
+                points.Add(spawnPoint);


this line should probably be in the if block above. If so, combine and invert the ifs

iamteapot422 · 2026-03-13T16:22:50Z

+        /// The data needed to validate the spawning conditions.
+        /// For example, checking whether the player can spawn on this SpawnPoint based on their job (e.g. an assistant can't spawn on security SpawnPoint)
+        /// </summary>
+        public SpawnPointData SpawnPointData;


Turn into public getter, private setter; serialize for unity inspector

iamteapot422 · 2026-03-13T16:56:43Z

+        }
+
+        /// <summary>
+        /// Synces the position of a networkobject with the spawn point


Suggested change

/// Synces the position of a networkobject with the spawn point

/// Syncs the position of a networkobject with the spawn point

iamteapot422 · 2026-03-13T17:01:31Z

+        /// </summary>
+        /// <param name="spawnPoints"></param> The spawn points to check
+        /// <returns></returns>
+        private SpawnPoint GetValidSpawnPoint(List<SpawnPoint> spawnPoints)


Annotate with [CanBeNull]

iamteapot422 · 2026-03-13T17:03:10Z

+        [Server]
+        public SpawnPoint HandleSpawning(Player player, bool isLateJoin)
+        {
+            RoleData roleData = _roleSubSystem.GetRoleFromPlayer(player);


Move this check to the else block below. Log an error, but return a LateJoin spawn

iamteapot422 · 2026-03-13T17:36:02Z

+        /// <param name="player"></param> The player we want to handle spawning for
+        /// <param name="isLateJoin"></param> Whether the entity is late-joining or not
+        [Server]
+        public SpawnPoint HandleSpawning(Player player, bool isLateJoin)


Rename to GetAvailableSpawnPoint

iamteapot422 · 2026-03-13T17:52:52Z

+        public RoundState RoundState
        {
            get => _roundState;
            set => _roundState = value;


Suggested change

set => _roundState = value;

protected set => _roundState = value;

Lumminal added 5 commits February 9, 2026 15:37

init

12b92a7

finish up

d36869d

add MapEditor layer so only map editor can see spawn points

817fd35

add comments and fix some things

2b20081

try fix client desync

2eb2dff

Lumminal marked this pull request as draft February 10, 2026 22:45

Lumminal added 3 commits February 11, 2026 00:48

remove unused function and dependencies

92e0908

fix some stuff and add assets

80ecef7

rewrite SpawnPointManager so its more optimized and add more comments

3c85296

Lumminal marked this pull request as ready for review February 13, 2026 16:09

Lumminal changed the title ~~[WIP] Add Spawn Points~~ Add Spawn Points Feb 13, 2026

iamteapot422 requested changes Mar 13, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add Spawn Points#1490

Add Spawn Points#1490
Lumminal wants to merge 8 commits intoRE-SS3D:developfrom
Lumminal:spawn-tiles

Lumminal commented Feb 10, 2026 •

edited

Loading

Uh oh!

Lumminal commented Feb 13, 2026

Uh oh!

iamteapot422 left a comment

Uh oh!

iamteapot422 Feb 20, 2026

Uh oh!

iamteapot422 Mar 13, 2026

Uh oh!

iamteapot422 Mar 13, 2026

Uh oh!

iamteapot422 Mar 13, 2026

Uh oh!

iamteapot422 Mar 13, 2026

Uh oh!

iamteapot422 Mar 13, 2026

Uh oh!

iamteapot422 Mar 13, 2026

Uh oh!

iamteapot422 Mar 13, 2026

Uh oh!

iamteapot422 Mar 13, 2026

Uh oh!

iamteapot422 Mar 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	/// Synces the position of a networkobject with the spawn point
	/// Syncs the position of a networkobject with the spawn point

	set => _roundState = value;
	protected set => _roundState = value;

Uh oh!

Conversation

Lumminal commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

PR checklist

Pictures/Videos

Testing

Networking checklist

Changes

Related issues/PRs

Uh oh!

Lumminal commented Feb 13, 2026

Uh oh!

iamteapot422 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Lumminal commented Feb 10, 2026 •

edited

Loading