receiverID and header input and output for all messages #42

Angeleon · 2023-07-21T13:57:17Z

As receiverID is desired for CARLA control, here is a suggestion for the first step on how to implement it.

iso22133.c

src/header.c

iso22133.c

src/traj.c

SebastianSvanland

Looks simple enough for the most part. Have you also checked so that all the decoders are correct still? Or did this not change anything significant in that regard?

iso22133.c

src/grem.c

src/dres.c

tests/header.cpp

tests/monr.cpp

tests/ostm.cpp

tests/traj.cpp

CMakeLists.txt

sepast

Nice work.
Does ATOS work with this PR?

include/header.h

src/header.c

…e parameter from now on

include/header.h

src/dres.c

src/header.c

src/ostm.c

src/traj.c

sepast

Looks good.
Some comments.
We need to review the ATOS branch with this branch before approval.

victorjarlow

Is swig necessary for the changes with receiver ID and header of the ISO protocol? If not, split into another PR that deals exclusively with swig-parts

include/header.h

iso22133.i

include/defines.h

src/dreq.c

src/dres.c

src/grem.c

iso22133.i

Co-authored-by: victorjarlow <[email protected]>

src/dreq.c

Co-authored-by: victorjarlow <[email protected]>

already discussed

receiverID and header input and output for all messages

80c9d27

Angeleon requested a review from Robert108 July 21, 2023 13:57

Changed everything regarding ReceiverID and messageCounter

9d3f71d

ceciliahernqvist reviewed Jul 26, 2023

View reviewed changes

iso22133.c Outdated Show resolved Hide resolved

src/header.c Show resolved Hide resolved

iso22133.c Show resolved Hide resolved

src/traj.c Outdated Show resolved Hide resolved

SebastianSvanland reviewed Jul 31, 2023

View reviewed changes

Patrik Lönnberg and others added 5 commits August 2, 2023 09:39

Fixed to heab

be70dd5

Added SWIG to makefile

119901b

Cleanup of CMakelist

a7bbe1b

iso22122.i warnings removed

470ce0c

fixed so you can swig iso22133 seperatly

6a8bb7b

Angeleon requested a review from sepast August 9, 2023 07:55

sepast reviewed Aug 9, 2023

View reviewed changes

CMakeLists.txt Show resolved Hide resolved

sepast reviewed Aug 9, 2023

View reviewed changes

include/header.h Show resolved Hide resolved

src/header.c Outdated Show resolved Hide resolved

Patrik Lönnberg added 3 commits August 10, 2023 08:54

HeaderType as input to encodeMessage functions and header

5eef405

Removed get/set transmitter id functions - only use through HeaderTyp…

1934fad

…e parameter from now on

Updated install in swig to work when included in other projects

2a649d7

sepast reviewed Aug 10, 2023

View reviewed changes

include/header.h Outdated Show resolved Hide resolved

Patrik Lönnberg added 5 commits August 11, 2023 13:04

Moved back header to header.h and used forward declaration instead

4d0b0e4

Extracted nested structs for SWIG reasons

52b84af

Created MessageHeaderType to hide internal header parts

f837bed

Updated README to instruct how to build with swig for python

491bd71

Made inputheader const

aa92279